jenkins-bot has submitted this change and it was merged.
Change subject: mw.loader.store: Count modules which fail to execute, too
......................................................................
mw.loader.store: Count modules which fail to execute, too
"Failed" will probably always be either zero or one, because it is
unlikely the asyncEval error callback can ever be called more than once.
But the stats will let us verify this, and will give us an indication of
how often errors happen in general.
Change-Id: I6dea28d84bbca0f02ad8c5bf9a8e9d976622d815
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/mediawiki.js
b/resources/src/mediawiki/mediawiki.js
index 6280c95..da4c769 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -1782,6 +1782,7 @@
// Depending on how
corrupt the string is, it is likely that some
// modules' implement()
succeeded while the ones after the error will
// never run and leave
their modules in the 'loading' state forever.
+
mw.loader.store.stats.failed++;
// Since this is an
error not caused by an individual module but by
// something that
infected the implement call itself, don't take any
@@ -2184,7 +2185,7 @@
items: {},
// Cache hit stats
- stats: { hits: 0, misses: 0, expired: 0
},
+ stats: { hits: 0, misses: 0, expired:
0, failed: 0 },
/**
* Construct a JSON-serializable object
representing the content of the store.
--
To view, visit https://gerrit.wikimedia.org/r/319389
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dea28d84bbca0f02ad8c5bf9a8e9d976622d815
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
