jenkins-bot has submitted this change and it was merged. Change subject: Add default page specific classes to minerva skin ......................................................................
Add default page specific classes to minerva skin All our skins add these and they are useful for both scripts and styling. Not having them only in Minverva is annoying and inconsistent. Change-Id: I2446e729d93ab8870c139b8e71ebf6d20b0f11d4 --- M includes/skins/SkinMinerva.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 47eac56..a98301f 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -240,7 +240,8 @@ * @return string */ public function getPageClasses( $title ) { - $className = $this->getMode(); + $className = parent::getPageClasses( $title ); + $className .= ' ' . $this->getMode(); if ( $title->isMainPage() ) { $className .= ' page-Main_Page '; } elseif ( $title->isSpecialPage() ) { -- To view, visit https://gerrit.wikimedia.org/r/319044 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2446e729d93ab8870c139b8e71ebf6d20b0f11d4 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits