Yuvipanda has submitted this change and it was merged.

Change subject: roles: Kill the 'notebook' roles
......................................................................


roles: Kill the 'notebook' roles

Is in paws_internal now

Change-Id: Idd577034a634c5c8049149d0d14c5efe401f5b81
---
D modules/role/manifests/notebook/server.pp
M modules/role/manifests/paws_internal/jupyterhub.pp
2 files changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Yuvipanda: Verified; Looks good to me, approved



diff --git a/modules/role/manifests/notebook/server.pp 
b/modules/role/manifests/notebook/server.pp
deleted file mode 100644
index dd27064..0000000
--- a/modules/role/manifests/notebook/server.pp
+++ /dev/null
@@ -1,5 +0,0 @@
-# stub role for experimental notebook servers
-class role::notebook::server {
-
-    include base::firewall
-}
diff --git a/modules/role/manifests/paws_internal/jupyterhub.pp 
b/modules/role/manifests/paws_internal/jupyterhub.pp
index 8de8687..2841a3a 100644
--- a/modules/role/manifests/paws_internal/jupyterhub.pp
+++ b/modules/role/manifests/paws_internal/jupyterhub.pp
@@ -4,6 +4,8 @@
 # See https://wikitech.wikimedia.org/wiki/PAWS/Internal for more info
 class role::paws_internal::jupyterhub {
 
+    include ::base::firewall
+
     class { '::jupyterhub':
         base_path   => '/srv/paws-internal',
         wheels_repo => 'operations/wheels/paws-internal',

-- 
To view, visit https://gerrit.wikimedia.org/r/319476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd577034a634c5c8049149d0d14c5efe401f5b81
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to