jenkins-bot has submitted this change and it was merged.
Change subject: Further e-notice fix.
......................................................................
Further e-notice fix.
Not sure if this happens in production but the test engage import csv triggers
e-notices here
Change-Id: I6184ecca10353a2c97eeeffe7fd40eeff8ef6b9b
---
M sites/all/modules/wmf_civicrm/wmf_civicrm.module
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Ejegg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
index 8b950dc..06913be 100644
--- a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
+++ b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
@@ -565,7 +565,7 @@
/**
* Determines which civi-only payment instrument is appropriate for the current
- * message, and resturns the civi payment instrument's human-readable display
+ * message, and returns the civi payment instrument's human-readable display
* string (if it exists).
*
* TODO lookup table
@@ -738,6 +738,10 @@
break;
case 'cash':
$payment_instrument = 'Cash';
+ if ( empty( $msg['payment_submethod'] ) ) {
+ watchdog( 'wmf_civicrm', 'No cash submethod given', NULL,
WATCHDOG_WARNING );
+ break;
+ }
switch ( strtolower( $msg['payment_submethod'] ) ){
case 'cash_boleto':
$payment_instrument = 'Boleto';
--
To view, visit https://gerrit.wikimedia.org/r/319492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6184ecca10353a2c97eeeffe7fd40eeff8ef6b9b
Gerrit-PatchSet: 3
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Eileen <emcnaugh...@wikimedia.org>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
