jenkins-bot has submitted this change and it was merged. Change subject: Fix processing listeners in node v7.x ......................................................................
Fix processing listeners in node v7.x * In https://github.com/nodejs/node/commit/b7a8a691b4, once listeners are now returned unwrapped, so our manual calling of them no longer removed them from the queue. Here we do that explicitly beforehand, which should be backwards compatible. Change-Id: Id8f42fddd71191d11d5dba60a01e9498d06c43a1 --- M lib/mw/ApiRequest.js 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Subramanya Sastry: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/mw/ApiRequest.js b/lib/mw/ApiRequest.js index 75d350f..a33f7ca 100644 --- a/lib/mw/ApiRequest.js +++ b/lib/mw/ApiRequest.js @@ -350,6 +350,7 @@ var maxIters = Math.min(1, listeners.length); for (var it = 0; it < maxIters; it++) { var nextListener = listeners.shift(); + self.removeListener('src', nextListener); // We only retrieve text/x-mediawiki source currently. // We expect these listeners to remove themselves when being -- To view, visit https://gerrit.wikimedia.org/r/319502 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8f42fddd71191d11d5dba60a01e9498d06c43a1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/parsoid Gerrit-Branch: master Gerrit-Owner: Arlolra <abrea...@wikimedia.org> Gerrit-Reviewer: Arlolra <abrea...@wikimedia.org> Gerrit-Reviewer: C. Scott Ananian <canan...@wikimedia.org> Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
