Mholloway has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319899
Change subject: Log missing @Required fields remotely when unmarshalling
......................................................................
Log missing @Required fields remotely when unmarshalling
...to address the "and remotely send error information" part of this task.
Bug: T145075
Change-Id: I59e7bb82a500d92feae9d717fe48ddc1d051bfc2
---
M
app/src/main/java/org/wikipedia/json/RequiredFieldsCheckOnReadTypeAdapterFactory.java
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/99/319899/1
diff --git
a/app/src/main/java/org/wikipedia/json/RequiredFieldsCheckOnReadTypeAdapterFactory.java
b/app/src/main/java/org/wikipedia/json/RequiredFieldsCheckOnReadTypeAdapterFactory.java
index 0e8852c..273e10d 100644
---
a/app/src/main/java/org/wikipedia/json/RequiredFieldsCheckOnReadTypeAdapterFactory.java
+++
b/app/src/main/java/org/wikipedia/json/RequiredFieldsCheckOnReadTypeAdapterFactory.java
@@ -12,6 +12,7 @@
import com.google.gson.stream.JsonWriter;
import org.wikipedia.json.annotations.Required;
+import org.wikipedia.util.log.L;
import java.io.IOException;
import java.lang.reflect.Field;
@@ -75,6 +76,9 @@
for (Field field : required) {
try {
if (field.get(deserialized) == null) {
+ L.logRemoteError(new JsonParseException("Received
object of type "
+ + deserialized.getClass().getName() + "
missing required field '"
+ + field.getName() +"'"));
return false;
}
} catch (IllegalArgumentException | IllegalAccessException e) {
--
To view, visit https://gerrit.wikimedia.org/r/319899
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59e7bb82a500d92feae9d717fe48ddc1d051bfc2
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
