jenkins-bot has submitted this change and it was merged.
Change subject: Fix possible memory leak(s) in feed.
......................................................................
Fix possible memory leak(s) in feed.
Observed in API 17, certain Clients that provide feed content seem
to retain a reference to a Context, which in this case is MainActivity.
This patch provides the FeedCoordinator with an Application context
instead of an Activity context, so that it won't matter if the coordinator
(or any Clients to which it passes the Context) holds on to the Context
longer than necessary.
Change-Id: Ia2603d0ccf57889d84a81d1b90f71cc88f78884d
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
M app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Niedzielski: Looks good to me, approved
diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index faeaa9d..4efad4a 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -83,7 +83,7 @@
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
app = WikipediaApp.getInstance();
- coordinator = new FeedCoordinator(getContext());
+ coordinator = new FeedCoordinator(app);
coordinator.more(app.getWikiSite());
funnel = new FeedFunnel(app);
}
diff --git
a/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
b/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
index 8c2393c..8813d65 100644
---
a/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
+++
b/app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
@@ -292,7 +292,7 @@
private void preRequestReadMoreItems(final LayoutInflater layoutInflater) {
if (parentFragment.getPage().isMainPage()) {
- new MainPageReadMoreTopicTask(parentFragment.getContext()) {
+ new MainPageReadMoreTopicTask(app) {
@Override
public void onFinish(HistoryEntry entry) {
requestReadMoreItems(layoutInflater, entry);
--
To view, visit https://gerrit.wikimedia.org/r/319064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2603d0ccf57889d84a81d1b90f71cc88f78884d
Gerrit-PatchSet: 5
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
