Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319923
Change subject: Put something in contribution_tracking.payments_form
......................................................................
Put something in contribution_tracking.payments_form
This used to hold ffname back in the RapidHTML days. It should have
something useful for A/B testing payments forms. These days the only
differentiators are the gateway and the appeal (for a hacky CSS
override).
Bug: T150055
Change-Id: If946e3f21b4d137512b0ccee6411627576b0ee03
---
M gateway_common/DonationData.php
1 file changed, 7 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/23/319923/1
diff --git a/gateway_common/DonationData.php b/gateway_common/DonationData.php
index 5363e6c..b11bd67 100644
--- a/gateway_common/DonationData.php
+++ b/gateway_common/DonationData.php
@@ -821,11 +821,13 @@
if ( $this->isSomething( 'currency_code' ) &&
$this->isSomething( 'amount' ) ) {
$tracking_data['form_amount'] = $this->getVal(
'currency_code' ) . " " . $this->getVal( 'amount' );
}
- if ( $this->isSomething( 'form_name' ) ) {
- $tracking_data['payments_form'] = $this->getVal(
'form_name' );
- if ( $this->isSomething( 'ffname' ) ) {
- $tracking_data['payments_form'] .= '.' .
$this->getVal( 'ffname' );
- }
+
+ $tracking_data['payments_form'] = $this->getVal( 'gateway' );
+
+ // FIXME: currently 'appeal' is the only way to A/B test
different CSS.
+ // Change this tracking element to 'ffname' when we restore
that.
+ if ( $this->isSomething( 'appeal' ) ) {
+ $tracking_data['payments_form'] .= '.' . $this->getVal(
'appeal' );
}
return $tracking_data;
--
To view, visit https://gerrit.wikimedia.org/r/319923
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If946e3f21b4d137512b0ccee6411627576b0ee03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
