Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320065
Change subject: Ensure inserted reference gets selected
......................................................................
Ensure inserted reference gets selected
Upstream changes means we can't rely on the surface
to expand the selection, so do it explicitly with
the surface fragment.
Change-Id: I44a67639dfa40728b8322e557d020c4a947c5557
---
M modules/ve.ui.CiteFromIdInspector.js
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Citoid
refs/changes/65/320065/1
diff --git a/modules/ve.ui.CiteFromIdInspector.js
b/modules/ve.ui.CiteFromIdInspector.js
index aa8f60a..b5e2e52 100644
--- a/modules/ve.ui.CiteFromIdInspector.js
+++ b/modules/ve.ui.CiteFromIdInspector.js
@@ -416,6 +416,7 @@
ve.ui.CiteFromIdInspector.prototype.getSetupProcess = function ( data ) {
return ve.ui.CiteFromIdInspector.super.prototype.getSetupProcess.call(
this, data )
.next( function () {
+ var fragment;
// Reset
this.lookupPromise = null;
@@ -441,12 +442,14 @@
if ( this.inDialog !== 'reference' ) {
this.staging = true;
+ fragment = this.getFragment();
// Stage an empty reference
-
this.getFragment().getSurface().pushStaging();
+ fragment.getSurface().pushStaging();
// Insert an empty reference
- this.referenceModel.insertInternalItem(
this.getFragment().getSurface() );
-
this.referenceModel.insertReferenceNode( this.getFragment(), true );
+ this.referenceModel.insertInternalItem(
fragment.getSurface() );
+
this.referenceModel.insertReferenceNode( fragment, true );
+ fragment.select();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/320065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44a67639dfa40728b8322e557d020c4a947c5557
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
