Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320088
Change subject: Test: Do not merge
......................................................................
Test: Do not merge
Change-Id: I26b0b996854e20682f5cd478c9891109cd14d00e
---
M includes/installer/MysqlUpdater.php
M includes/installer/SqliteUpdater.php
A maintenance/archives/patch-l10n_cache-primary-key.sql
A maintenance/sqlite/archives/patch-l10n_cache-primary-key.sql
M maintenance/tables.sql
5 files changed, 18 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/88/320088/1
diff --git a/includes/installer/MysqlUpdater.php
b/includes/installer/MysqlUpdater.php
index a637ce0..dd4a163 100644
--- a/includes/installer/MysqlUpdater.php
+++ b/includes/installer/MysqlUpdater.php
@@ -291,6 +291,7 @@
[ 'addField', 'change_tag', 'ct_id',
'patch-change_tag-ct_id.sql' ],
[ 'addField', 'tag_summary', 'ts_id',
'patch-tag_summary-ts_id.sql' ],
[ 'modifyField', 'recentchanges', 'rc_ip',
'patch-rc_ip_modify.sql' ],
+ [ 'dropIndex', 'l10n_cache', 'lc_lang_key',
'patch-l10n_cache-primary-key.sql' ],
];
}
diff --git a/includes/installer/SqliteUpdater.php
b/includes/installer/SqliteUpdater.php
index 388c034..996a580 100644
--- a/includes/installer/SqliteUpdater.php
+++ b/includes/installer/SqliteUpdater.php
@@ -158,6 +158,7 @@
'patch-add-rc_name_type_patrolled_timestamp_index.sql' ],
[ 'addField', 'change_tag', 'ct_id',
'patch-change_tag-ct_id.sql' ],
[ 'addField', 'tag_summary', 'ts_id',
'patch-tag_summary-ts_id.sql' ],
+ [ 'dropIndex', 'l10n_cache', 'lc_lang_key',
'patch-l10n_cache-primary-key.sql' ],
];
}
diff --git a/maintenance/archives/patch-l10n_cache-primary-key.sql
b/maintenance/archives/patch-l10n_cache-primary-key.sql
new file mode 100644
index 0000000..2c5154f
--- /dev/null
+++ b/maintenance/archives/patch-l10n_cache-primary-key.sql
@@ -0,0 +1,7 @@
+--
+-- patch-l10n_cache-primary-key.sql
+--
+-- Bug T146591. Add l10n_cache primary key
+DROP INDEX IF EXISTS lc_lang_key;
+
+ALTER TABLE /*$wgDBprefix*/l10n_cache ADD PRIMARY KEY (lc_lang, lc_key);
diff --git a/maintenance/sqlite/archives/patch-l10n_cache-primary-key.sql
b/maintenance/sqlite/archives/patch-l10n_cache-primary-key.sql
new file mode 100644
index 0000000..2c5154f
--- /dev/null
+++ b/maintenance/sqlite/archives/patch-l10n_cache-primary-key.sql
@@ -0,0 +1,7 @@
+--
+-- patch-l10n_cache-primary-key.sql
+--
+-- Bug T146591. Add l10n_cache primary key
+DROP INDEX IF EXISTS lc_lang_key;
+
+ALTER TABLE /*$wgDBprefix*/l10n_cache ADD PRIMARY KEY (lc_lang, lc_key);
diff --git a/maintenance/tables.sql b/maintenance/tables.sql
index 03ce508..bcc44db 100644
--- a/maintenance/tables.sql
+++ b/maintenance/tables.sql
@@ -1522,9 +1522,9 @@
-- Cache key
lc_key varchar(255) NOT NULL,
-- Value
- lc_value mediumblob NOT NULL
+ lc_value mediumblob NOT NULL,
+ PRIMARY KEY (lc_lang, lc_key)
) /*$wgDBTableOptions*/;
-CREATE INDEX /*i*/lc_lang_key ON /*_*/l10n_cache (lc_lang, lc_key);
-- Table caching which local files a module depends on that aren't
-- registered directly, used for fast retrieval of file dependency.
--
To view, visit https://gerrit.wikimedia.org/r/320088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26b0b996854e20682f5cd478c9891109cd14d00e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Tjlsangria <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
