Fomafix has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320091
Change subject: Use mw.msg() for parameter substitution
......................................................................
Use mw.msg() for parameter substitution
mw.msg() has already a parameter substitution of $1.
A separate .replace( '$1', ... ) is not necessary.
Change-Id: Ie77bddc4dfb60df36211ce821c1a6f7223cde706
---
M resources/js/ext.uls.ime.js
M resources/js/ext.uls.inputsettings.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/91/320091/1
diff --git a/resources/js/ext.uls.ime.js b/resources/js/ext.uls.ime.js
index 8871346..5ebca05 100644
--- a/resources/js/ext.uls.ime.js
+++ b/resources/js/ext.uls.ime.js
@@ -301,7 +301,7 @@
helpHandler: function ( ime ) {
return $( '<a>' )
.attr( {
- href: mw.msg(
'uls-ime-helppage' ).replace( '$1', ime ),
+ href: mw.msg(
'uls-ime-helppage', ime ),
target: '_blank',
title: $.i18n(
'ext-uls-ime-help' )
} )
diff --git a/resources/js/ext.uls.inputsettings.js
b/resources/js/ext.uls.inputsettings.js
index dd3e871..f977530 100644
--- a/resources/js/ext.uls.inputsettings.js
+++ b/resources/js/ext.uls.inputsettings.js
@@ -189,7 +189,7 @@
$helplink = $( '<a>' )
.addClass( 'uls-ime-help' )
.text( $.i18n( 'ext-uls-ime-help' ) )
- .attr( 'href', mw.msg(
'uls-ime-helppage' ).replace( '$1', imeId ) )
+ .attr( 'href', mw.msg(
'uls-ime-helppage', imeId ) )
.attr( 'target', '_blank' );
if ( !inputmethod ) {
// The input method definition(rules)
not loaded.
--
To view, visit https://gerrit.wikimedia.org/r/320091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie77bddc4dfb60df36211ce821c1a6f7223cde706
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Fomafix <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
