jenkins-bot has submitted this change and it was merged.
Change subject: PageAssignments: Improved API performance
......................................................................
PageAssignments: Improved API performance
Now generating links on the client
Change-Id: I6798af5fa6d1f2eefe8f6cddd8fd354d7db6bd13
---
M PageAssignments/includes/api/BSApiPageAssignmentStore.php
M PageAssignments/resources/BS.PageAssignments/panel/Manager.js
2 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Mglaser: Looks good to me, approved
jenkins-bot: Verified
diff --git a/PageAssignments/includes/api/BSApiPageAssignmentStore.php
b/PageAssignments/includes/api/BSApiPageAssignmentStore.php
index 6150f43..5c23b9a 100644
--- a/PageAssignments/includes/api/BSApiPageAssignmentStore.php
+++ b/PageAssignments/includes/api/BSApiPageAssignmentStore.php
@@ -13,7 +13,6 @@
$oDataSet = (object)array(
'page_id' => $oTitle->getArticleID(),
'page_prefixedtext' =>
$oTitle->getPrefixedText(),
- 'page_link' => Linker::link( $oTitle ),
'assignments' => array()
);
diff --git a/PageAssignments/resources/BS.PageAssignments/panel/Manager.js
b/PageAssignments/resources/BS.PageAssignments/panel/Manager.js
index 320033b..3322d9f 100644
--- a/PageAssignments/resources/BS.PageAssignments/panel/Manager.js
+++ b/PageAssignments/resources/BS.PageAssignments/panel/Manager.js
@@ -11,7 +11,16 @@
sortable: true,
filterable:true,
renderer: function( value, metaData, record,
rowIndex, colIndex, store, view ) {
- return record.get('page_link');
+ var title = new mw.Title( value );
+ return mw.html.element(
+ 'a',
+ {
+ 'href': title.getUrl(),
+ 'data-bs-title': value,
+ 'target': '_blank'
+ },
+ value
+ );
}
},
{
--
To view, visit https://gerrit.wikimedia.org/r/320119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6798af5fa6d1f2eefe8f6cddd8fd354d7db6bd13
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel <vo...@hallowelt.biz>
Gerrit-Reviewer: Dvogel hallowelt <daniel.vo...@hallowelt.com>
Gerrit-Reviewer: Ljonka <l.verhovs...@gmail.com>
Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz>
Gerrit-Reviewer: Pwirth <wi...@hallowelt.biz>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
