Mobrovac has submitted this change and it was merged.
Change subject: Use standardised HTTPError
......................................................................
Use standardised HTTPError
Change-Id: I522bc288a665b9a238fbe9757a2190cef3c58d90
---
M routes/v1.js
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Mobrovac: Verified; Looks good to me, approved
diff --git a/routes/v1.js b/routes/v1.js
index bca1ad5..ec7c576 100644
--- a/routes/v1.js
+++ b/routes/v1.js
@@ -26,11 +26,7 @@
* TRENDING ENDPOINTS *
****************************/
-var error = {
- error: {
- message: 'Trending is currently not available on this wiki.'
- }
-};
+var ERROR_UNAVAILABLE = 'Trending is currently not available on this wiki.';
/**
* GET /page/{title}
@@ -48,7 +44,12 @@
} else {
// These are not implemented yet. The hope is to be able to trend
// the language equivalent of the english article.
- res.status(501).type('application/json').end(JSON.stringify(error));
+ throw new HTTPError({
+ status: 501,
+ type: 'not_implemented',
+ title: 'Not implemented',
+ detail: ERROR_UNAVAILABLE
+ });
}
});
--
To view, visit https://gerrit.wikimedia.org/r/319830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I522bc288a665b9a238fbe9757a2190cef3c58d90
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
