Amritsreekumar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320411
Change subject: Change Checkboxes from right to left of Labels
......................................................................
Change Checkboxes from right to left of Labels
The Checkboxes on Special:BotPasswords should be moved from right to left for
the convenience of the users.
Bug: T150079
Change-Id: I66e7fbcdc5299297ec3bfe0a9b503f8fa17b2e16
---
M includes/htmlform/fields/HTMLCheckMatrix.php
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/11/320411/1
diff --git a/includes/htmlform/fields/HTMLCheckMatrix.php
b/includes/htmlform/fields/HTMLCheckMatrix.php
index b324fb6..e420fd8 100644
--- a/includes/htmlform/fields/HTMLCheckMatrix.php
+++ b/includes/htmlform/fields/HTMLCheckMatrix.php
@@ -88,9 +88,9 @@
$attribs = $this->getAttributes( [ 'disabled', 'tabindex' ] );
// Build the column headers
- $headerContents = Html::rawElement( 'td', [], ' ' );
+ $headerContents = Html::rawElement( 'tr', [], ' ' );
foreach ( $columns as $columnLabel => $columnTag ) {
- $headerContents .= Html::rawElement( 'td', [],
$columnLabel );
+ $headerContents .= Html::rawElement( 'tr', [],
$columnLabel );
}
$tableContents .= Html::rawElement( 'tr', [],
"\n$headerContents\n" );
@@ -109,7 +109,6 @@
];
$rowLabel .= ' ' . Html::element( 'span',
$tooltipAttribs, '' );
}
- $rowContents = Html::rawElement( 'td', [], $rowLabel );
foreach ( $columns as $columnTag ) {
$thisTag = "$columnTag-$rowTag";
// Construct the checkbox
@@ -127,11 +126,12 @@
}
$checkbox = $this->getOneCheckbox( $checked,
$attribs + $thisAttribs );
+ $rowContents = Html::rawElement( 'td', [], $checkbox );
$rowContents .= Html::rawElement(
'td',
[],
- $checkbox
+ $rowLabel
);
}
$tableContents .= Html::rawElement( 'tr', [],
"\n$rowContents\n" );
--
To view, visit https://gerrit.wikimedia.org/r/320411
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66e7fbcdc5299297ec3bfe0a9b503f8fa17b2e16
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Amritsreekumar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
