Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320708
Change subject: PopupElement: Allow $autoCloseIgnore to be overridden
......................................................................
PopupElement: Allow $autoCloseIgnore to be overridden
PopupElement needs to ensure that this.$element is auto-close-ignored,
but it can accomplish this by adding it to $autoCloseIgnore
rather than overriding it.
Change-Id: I81dd678024d218f77f761546e72a536f66218986
---
M src/mixins/PopupElement.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/08/320708/1
diff --git a/src/mixins/PopupElement.js b/src/mixins/PopupElement.js
index 98da819..8846452 100644
--- a/src/mixins/PopupElement.js
+++ b/src/mixins/PopupElement.js
@@ -20,7 +20,7 @@
this.popup = new OO.ui.PopupWidget( $.extend(
{ autoClose: true },
config.popup,
- { $autoCloseIgnore: this.$element }
+ { $autoCloseIgnore: this.$element.add( config.popup &&
config.popup.$autoCloseIgnore ) }
) );
};
--
To view, visit https://gerrit.wikimedia.org/r/320708
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81dd678024d218f77f761546e72a536f66218986
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Catrope <r...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
