Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321369
Change subject: WPB enable banners on diff pages
......................................................................
WPB enable banners on diff pages
Bug: T147946
Change-Id: I64415799b2403db568a06295d1d79cf8d3d987bd
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 2 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/69/321369/1
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index a87290d..f7d4cf2 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -84,11 +84,10 @@
}
$config = WikidataPageBannerFunctions::getWPBConfig();
$title = $out->getTitle();
- $isDiff = $out->getRequest()->getCheck( 'diff' );
$wpbFunctionsClass = self::$wpbFunctionsClass;
// if banner-options are set and not a diff page, add banner
anyway
- if ( $out->getProperty( 'wpb-banner-options' ) !== null &&
!$isDiff ) {
+ if ( $out->getProperty( 'wpb-banner-options' ) !== null ) {
$params = $out->getProperty( 'wpb-banner-options' );
$bannername = $params['name'];
if ( isset( $params['icons'] ) ){
@@ -114,8 +113,7 @@
} elseif (
$title->isKnown() &&
$out->isArticle() &&
- $config->get( 'WPBEnableDefaultBanner' ) &&
- !$isDiff
+ $config->get( 'WPBEnableDefaultBanner' )
) {
// if the page uses no 'PAGEBANNER' invocation and if
article page, insert default banner
$ns = $title->getNamespace();
--
To view, visit https://gerrit.wikimedia.org/r/321369
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64415799b2403db568a06295d1d79cf8d3d987bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
