jenkins-bot has submitted this change and it was merged. Change subject: Downgrade missing details to warning for RecordCaptureJob ......................................................................
Downgrade missing details to warning for RecordCaptureJob We'll eventually get them from the logs when we parse the audit. Change-Id: Id82c4ec731c4e9652db6571bd9fcaa30e469327e --- M PaymentProviders/Adyen/Jobs/RecordCaptureJob.php 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Cdentinger: Looks good to me, approved jenkins-bot: Verified diff --git a/PaymentProviders/Adyen/Jobs/RecordCaptureJob.php b/PaymentProviders/Adyen/Jobs/RecordCaptureJob.php index 2db5924..bdcb117 100644 --- a/PaymentProviders/Adyen/Jobs/RecordCaptureJob.php +++ b/PaymentProviders/Adyen/Jobs/RecordCaptureJob.php @@ -65,8 +65,13 @@ $db->deleteMessage( $dbMessage ); } else { - $logger->error( - "Could not find a processable message for authorization Reference '{$this->originalReference}' " . + // Sometimes we don't have a pending db row because the donor made + // multiple attempts with the same order ID. It would be nice if + // Adyen could prevent that, but let's not send a failmail since + // we'll eventually get the donor details from the payments log + // when we parse the audit. + $logger->warning( + "Could not find donor details for authorization Reference '{$this->originalReference}' " . "and order ID '{$this->merchantReference}'.", $dbMessage ); -- To view, visit https://gerrit.wikimedia.org/r/319373 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id82c4ec731c4e9652db6571bd9fcaa30e469327e Gerrit-PatchSet: 4 Gerrit-Project: wikimedia/fundraising/SmashPig Gerrit-Branch: master Gerrit-Owner: Ejegg <eeggles...@wikimedia.org> Gerrit-Reviewer: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits