Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/321852

Change subject: Fix PHPDoc and JSDoc tags
......................................................................

Fix PHPDoc and JSDoc tags

Some typos and minor mistakes.

No curly brackets in PHP, but in JavaScript.

@return (without "s") for consistency.

Change-Id: I427b22b13922dbb5620fe502675389ab3096601d
---
M includes/devices/DeviceDetector.php
M includes/diff/InlineDifferenceEngine.php
M includes/skins/SkinMinerva.php
M includes/specials/SpecialMobileWatchlist.php
M resources/mobile.browser/browser.js
M resources/mobile.cache/Cache.js
M resources/mobile.categories.overlays/CategoryGateway.js
M resources/mobile.context/context.js
M resources/mobile.editor.api/EditorGateway.js
M resources/mobile.languages.structured/util.js
M resources/mobile.mainMenu/MainMenu.js
M resources/mobile.mediaViewer/ImageGateway.js
M resources/mobile.modifiedBar/time.js
M resources/mobile.nearby/Nearby.js
M resources/mobile.references.gateway/ReferencesGateway.js
M resources/mobile.settings/settings.js
M resources/mobile.startup/OverlayManager.js
M resources/mobile.startup/Page.js
M resources/mobile.startup/PageGateway.js
M resources/mobile.startup/Skin.js
M resources/mobile.startup/util.js
M resources/mobile.toggle/toggle.js
M resources/mobile.user/user.js
M resources/mobile.view/View.js
M resources/mobile.watchlist/WatchListGateway.js
M resources/skins.minerva.editor/init.js
M resources/skins.minerva.newusers/init.js
M resources/skins.minerva.notifications/init.js
M resources/skins.minerva.scripts/init.js
M resources/skins.minerva.scripts/mobileRedirect.js
M resources/skins.minerva.scripts/references.js
M tests/phpunit/MobileContextTest.php
32 files changed, 63 insertions(+), 63 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/52/321852/1

diff --git a/includes/devices/DeviceDetector.php 
b/includes/devices/DeviceDetector.php
index 5ef72b4..aa5399a 100644
--- a/includes/devices/DeviceDetector.php
+++ b/includes/devices/DeviceDetector.php
@@ -43,7 +43,7 @@
         *
         * @param WebRequest $request
         * @param array $server Per the above, the `$_SERVER` superglobal
-        * @return {DeviceProperties|null}
+        * @return DeviceProperties|null
         */
        function detectDeviceProperties( WebRequest $request, array $server );
 }
diff --git a/includes/diff/InlineDifferenceEngine.php 
b/includes/diff/InlineDifferenceEngine.php
index f8eb104..8fdd364 100644
--- a/includes/diff/InlineDifferenceEngine.php
+++ b/includes/diff/InlineDifferenceEngine.php
@@ -139,7 +139,7 @@
         * Returns the cache key for diff body text or content.
         *
         * @throws Exception when no mOldid and mNewid is set
-        * @see DifferenceEngine:getDiffBodyCacheKey
+        * @see DifferenceEngine::getDiffBodyCacheKey
         * @return string
         */
        protected function getDiffBodyCacheKey() {
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index a98301f..b44ed65 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -300,7 +300,7 @@
 
        /**
         * Returns, if Extension:Echo should be used.
-        * return boolean
+        * @return bool
         */
        protected function useEcho() {
                return class_exists( 'MWEchoNotifUser' );
@@ -737,7 +737,7 @@
        }
        /**
         * Returns the HTML representing the tagline
-        * @returns string html for tagline
+        * @return string HTML for tagline
         */
        protected function getTaglineHtml() {
                $tagline = false;
@@ -762,7 +762,7 @@
        }
        /**
         * Returns the HTML representing the heading.
-        * @returns {String} html for header
+        * @return string HTML for header
         */
        protected function getHeadingHtml() {
                $heading = '';
diff --git a/includes/specials/SpecialMobileWatchlist.php 
b/includes/specials/SpecialMobileWatchlist.php
index 48c80e6..511a19a 100644
--- a/includes/specials/SpecialMobileWatchlist.php
+++ b/includes/specials/SpecialMobileWatchlist.php
@@ -133,7 +133,7 @@
 
        /**
         * Get the header for the watchlist page
-        * @param User user
+        * @param User $user
         * @return string Parsed HTML
         */
        public static function getWatchlistHeader( User $user ) {
diff --git a/resources/mobile.browser/browser.js 
b/resources/mobile.browser/browser.js
index d6a48cd..a2659cf 100644
--- a/resources/mobile.browser/browser.js
+++ b/resources/mobile.browser/browser.js
@@ -6,7 +6,7 @@
         * arguments. Instances do not share a cache.
         * @ignore
         * @param {Function} method Method to be memoized
-        * @returns {Function}
+        * @return {Function}
         */
        function memoize( method ) {
                /**
@@ -134,7 +134,7 @@
                 * former.
                 * See http://stackoverflow.com/a/12621264/365238
                 *
-                * @returns {Boolean}
+                * @return {Boolean}
                 */
                supportsAnimations: memoize( function () {
                        // don't trust Android 2.x, really
@@ -195,7 +195,7 @@
 
        /**
         * @static
-        * @returns {Browser}
+        * @return {Browser}
         */
        Browser.getSingleton = function () {
                if ( !browser ) {
diff --git a/resources/mobile.cache/Cache.js b/resources/mobile.cache/Cache.js
index 17735a4..14a8d4f 100644
--- a/resources/mobile.cache/Cache.js
+++ b/resources/mobile.cache/Cache.js
@@ -20,7 +20,7 @@
         * Retrieve a cached value from a key
         * @method get
         * @param {String} key
-        * @returns {*}
+        * @return {*}
         */
        MemoryCache.prototype.get = function ( key ) {
                return this._cache[ key ];
diff --git a/resources/mobile.categories.overlays/CategoryGateway.js 
b/resources/mobile.categories.overlays/CategoryGateway.js
index 2b16ba8..356d348 100644
--- a/resources/mobile.categories.overlays/CategoryGateway.js
+++ b/resources/mobile.categories.overlays/CategoryGateway.js
@@ -22,7 +22,7 @@
                 * Saves the categories passed to this function to the page
                 * @param {String} title Title of the current page (to add the 
categories to)
                 * @param {String} categories List of Categories to add
-                * @returns {jQuery.Deferred}
+                * @return {jQuery.Deferred}
                 */
                save: function ( title, categories ) {
                        return this.api.postWithToken( 'edit', {
@@ -36,7 +36,7 @@
                /**
                 * Returns the categories the title belongs to.
                 * @param {String} title Title of the current page (to add the 
categories to)
-                * @returns {jQuery.Deferred|Boolean} False, if no further 
continuation is possible, jQuery.Deferred otherwise.
+                * @return {jQuery.Deferred|Boolean} False, if no further 
continuation is possible, jQuery.Deferred otherwise.
                 */
                getCategories: function ( title ) {
                        var self = this;
diff --git a/resources/mobile.context/context.js 
b/resources/mobile.context/context.js
index 1b5bd70..2f4741b 100644
--- a/resources/mobile.context/context.js
+++ b/resources/mobile.context/context.js
@@ -11,7 +11,7 @@
                /**
                 * Gets current mobile mode
                 * @method
-                * @returns {String} Name of mode
+                * @return {String} Name of mode
                 */
                getMode: function () {
                        return mw.config.get( 'wgMFMode' );
diff --git a/resources/mobile.editor.api/EditorGateway.js 
b/resources/mobile.editor.api/EditorGateway.js
index 064c775..e8479d1 100644
--- a/resources/mobile.editor.api/EditorGateway.js
+++ b/resources/mobile.editor.api/EditorGateway.js
@@ -23,7 +23,7 @@
                /**
                 * Get the content of a page.
                 * @method
-                * @returns {jQuery.Deferred}
+                * @return {jQuery.Deferred}
                 */
                getContent: function () {
                        var options,
@@ -235,7 +235,7 @@
                 * Get page preview from the API and abort any existing 
previews.
                 * @method
                 * @param {Object} options API query parameters
-                * @returns {jQuery.Deferred}
+                * @return {jQuery.Deferred}
                 */
                getPreview: function ( options ) {
                        var result = $.Deferred(),
diff --git a/resources/mobile.languages.structured/util.js 
b/resources/mobile.languages.structured/util.js
index a823481..dd6e792 100644
--- a/resources/mobile.languages.structured/util.js
+++ b/resources/mobile.languages.structured/util.js
@@ -17,7 +17,7 @@
         * @ignore
         * @param {Object[]} languages list of language objects as returned by 
the API
         * @param {String|undefined} deviceLanguage the device's primary 
language
-        * @returns {String|undefined} Return undefined if the article is not 
available in
+        * @return {String|undefined} Return undefined if the article is not 
available in
         *  the (general or variant) device language
         */
        function getDeviceLanguageOrParent( languages, deviceLanguage ) {
@@ -138,7 +138,7 @@
        /**
         * Return a map of frequently used languages on the current device.
         *
-        * @returns {Object}
+        * @return {Object}
         */
        util.getFrequentlyUsedLanguages = function () {
                var languageMap = mw.storage.get( 'langMap' );
diff --git a/resources/mobile.mainMenu/MainMenu.js 
b/resources/mobile.mainMenu/MainMenu.js
index 17c8f7a..86083fa 100644
--- a/resources/mobile.mainMenu/MainMenu.js
+++ b/resources/mobile.mainMenu/MainMenu.js
@@ -35,7 +35,7 @@
                 * Advertise a new feature in the main menu.
                 * @param {String} selector to an element inside the main menu
                 * @param {String} msg a message to show in the pointer
-                * @returns {jQuery.Deferred} with the PointerOverlay as the 
only argument.
+                * @return {jQuery.Deferred} with the PointerOverlay as the 
only argument.
                 * @throws exception when you try to advertise more than one 
feature.
                 */
                advertiseNewFeature: function ( selector, msg ) {
diff --git a/resources/mobile.mediaViewer/ImageGateway.js 
b/resources/mobile.mediaViewer/ImageGateway.js
index f16611d..d7b1e0b 100644
--- a/resources/mobile.mediaViewer/ImageGateway.js
+++ b/resources/mobile.mediaViewer/ImageGateway.js
@@ -28,7 +28,7 @@
                /**
                 * Get thumbnail via the API and cache it. Return the result 
from the cache if exists.
                 * @param {String} title Url of image
-                * @returns {jQuery.Deferred} with the image info
+                * @return {jQuery.Deferred} with the image info
                 */
                getThumb: function ( title ) {
                        var result = this._cache[title],
diff --git a/resources/mobile.modifiedBar/time.js 
b/resources/mobile.modifiedBar/time.js
index 541110c..f1f08d8 100644
--- a/resources/mobile.modifiedBar/time.js
+++ b/resources/mobile.modifiedBar/time.js
@@ -5,7 +5,7 @@
        /**
         * Calculate the correct unit of timestamp
         * @param {Number} timestampDelta
-        * @returns {{value: Number, unit: String}}
+        * @return {{value: Number, unit: String}}
         * @ignore
         */
        function timeAgo( timestampDelta ) {
@@ -22,7 +22,7 @@
        /**
         * Calculate the correct unit of timestamp delta
         * @param {Number} timestamp
-        * @returns {{value: Number, unit: String}}
+        * @return {{value: Number, unit: String}}
         * @ignore
         */
        function getTimeAgoDelta( timestamp ) {
@@ -34,7 +34,7 @@
        /**
         * Whether timestamp delta is less than a day old
         * @param {{value: Number, unit: String}} delta Object of timestamp and 
its label
-        * @returns {Boolean}
+        * @return {Boolean}
         * @ignore
         */
        function isRecent( delta ) {
@@ -45,7 +45,7 @@
        /**
         * Is delta less than 10 seconds?
         * @param {{value: Number, unit: String}} delta Object of timestamp and 
its label
-        * @returns {Boolean}
+        * @return {Boolean}
         * @ignore
         */
        function isNow( delta ) {
diff --git a/resources/mobile.nearby/Nearby.js 
b/resources/mobile.nearby/Nearby.js
index 80cfab1..00a7660 100644
--- a/resources/mobile.nearby/Nearby.js
+++ b/resources/mobile.nearby/Nearby.js
@@ -172,7 +172,7 @@
                 * @private
                 * @param {String} key to a defined error message
                 * @param {String} msg Message to use, instead of a mapped 
error message from this.errorMessages
-                * @returns {Object}
+                * @return {Object}
                 */
                _errorOptions: function ( key, msg ) {
                        var message;
diff --git a/resources/mobile.references.gateway/ReferencesGateway.js 
b/resources/mobile.references.gateway/ReferencesGateway.js
index 6f63610..5503a73 100644
--- a/resources/mobile.references.gateway/ReferencesGateway.js
+++ b/resources/mobile.references.gateway/ReferencesGateway.js
@@ -20,7 +20,7 @@
                 * @method
                 * @param {String} id CSS selector
                 * @param {Page} page to find reference for
-                * @returns {jQuery.Promise} resolves with an Object 
representing reference with a `text` property
+                * @return {jQuery.Promise} resolves with an Object 
representing reference with a `text` property
                 *  or false if the reference does not exist
                 */
                getReference: function () {
diff --git a/resources/mobile.settings/settings.js 
b/resources/mobile.settings/settings.js
index 9cb4fc2..738aea8 100644
--- a/resources/mobile.settings/settings.js
+++ b/resources/mobile.settings/settings.js
@@ -10,7 +10,7 @@
                        /**
                         * Checks whether cookies are enabled
                         * @method
-                        * @returns {Boolean} Whether cookies are enabled
+                        * @return {Boolean} Whether cookies are enabled
                         */
                        function cookiesEnabled() {
                                // If session cookie already set, return true
@@ -32,7 +32,7 @@
                         * @param {String} value The value to store alongside 
the key
                         * @param {Boolean} [useCookieFallback] When set this 
will use
                         * cookies when local storage not available.
-                        * @returns {Boolean} Whether the save was successful 
or not
+                        * @return {Boolean} Whether the save was successful or 
not
                         */
                        function save( name, value, useCookieFallback ) {
                                var success = mw.storage.set( name, value ),
@@ -49,7 +49,7 @@
                         * @param {String} name The key to refer to this value
                         * @param {Boolean} [useCookieFallback] When set this 
will use cookies
                         * when local storage not available.
-                        * @returns {String|Boolean} Returns the associated 
value or False if nothing
+                        * @return {String|Boolean} Returns the associated 
value or False if nothing
                         * is found
                         */
                        function get( name, useCookieFallback ) {
@@ -66,7 +66,7 @@
                         * @param {String} name The key to refer to this value
                         * @param {Boolean} [useCookieFallback] When set this 
will use cookies
                         * when local storage not available.
-                        * @returns {Boolean} Whether the delete was successful 
or not
+                        * @return {Boolean} Whether the delete was successful 
or not
                         */
                        function remove( name, useCookieFallback ) {
                                var success = mw.storage.remove( name );
diff --git a/resources/mobile.startup/OverlayManager.js 
b/resources/mobile.startup/OverlayManager.js
index c0a9a6b..14dea9d 100644
--- a/resources/mobile.startup/OverlayManager.js
+++ b/resources/mobile.startup/OverlayManager.js
@@ -52,7 +52,7 @@
                 * @method
                 * @private
                 * @param {Overlay} overlay to hide
-                * @returns {Boolean} Whether the overlay has been hidden
+                * @return {Boolean} Whether the overlay has been hidden
                 */
                _hideOverlay: function ( overlay ) {
                        var result;
diff --git a/resources/mobile.startup/Page.js b/resources/mobile.startup/Page.js
index 9b1e9ca..f60ec91 100644
--- a/resources/mobile.startup/Page.js
+++ b/resources/mobile.startup/Page.js
@@ -296,7 +296,7 @@
         *
         * @static
         * @param {Object} resp as representing a page in the API
-        * @returns {Page}
+        * @return {Page}
         */
        Page.newFromJSON = function ( resp ) {
                var revision, displayTitle,
diff --git a/resources/mobile.startup/PageGateway.js 
b/resources/mobile.startup/PageGateway.js
index 3e437ef..a433cf1 100644
--- a/resources/mobile.startup/PageGateway.js
+++ b/resources/mobile.startup/PageGateway.js
@@ -34,7 +34,7 @@
         * @private
         * @ignore
         * @param {Array} sections Array of section objects created from 
response HTML
-        * @returns {Array} Ordered array of sections
+        * @return {Array} Ordered array of sections
         */
        function transformSections( sections ) {
                var
@@ -274,7 +274,7 @@
                 * @method
                 * @private
                 * @param {jQuery.Object} $el object from which sections are 
extracted
-                * @returns {Array} Array of section objects created from 
headings in $el
+                * @return {Array} Array of section objects created from 
headings in $el
                 * FIXME: Where's a better place for these two functions to 
live?
                 */
                _getAPIResponseFromHTML: function ( $el ) {
@@ -301,7 +301,7 @@
                 * Order sections hierarchically
                 * @method
                 * @param {jQuery.Object} $el object from which sections are 
extracted
-                * @returns {Array} Ordered array of sections
+                * @return {Array} Ordered array of sections
                 */
                getSectionsFromHTML: function ( $el ) {
                        return transformSections( this._getAPIResponseFromHTML( 
$el ) );
diff --git a/resources/mobile.startup/Skin.js b/resources/mobile.startup/Skin.js
index 1b53c19..19caae6 100644
--- a/resources/mobile.startup/Skin.js
+++ b/resources/mobile.startup/Skin.js
@@ -151,7 +151,7 @@
 
                /**
                 * Return the instance of MainMenu
-                * @returns {MainMenu}
+                * @return {MainMenu}
                 */
                getMainMenu: function () {
                        return this.mainMenu;
@@ -241,19 +241,19 @@
                },
 
                /**
-               * Load the references section content from API if it's not 
already loaded.
-               *
-               * All references tags content will be loaded per section.
-               *
-               * @param {Object} data Information about the section. It's in 
the following form:
-               *  {
-               *      @property {String} page,
-               *      @property {Boolean} wasExpanded,
-               *      @property {jQuery.Object} $heading,
-               *      @property {Boolean} isReferenceSection
-               * }
-               * @returns {jQuery.Deferred} rejected when not a reference 
section.
-               */
+                * Load the references section content from API if it's not 
already loaded.
+                *
+                * All references tags content will be loaded per section.
+                *
+                * @param {Object} data Information about the section. It's in 
the following form:
+                * {
+                *     @property {String} page,
+                *     @property {Boolean} wasExpanded,
+                *     @property {jQuery.Object} $heading,
+                *     @property {Boolean} isReferenceSection
+                * }
+                * @return {jQuery.Deferred} rejected when not a reference 
section.
+                */
                lazyLoadReferences: function ( data ) {
                        var $content, $spinner,
                                gateway = this.referencesGateway,
diff --git a/resources/mobile.startup/util.js b/resources/mobile.startup/util.js
index d3573ec..513f1f7 100644
--- a/resources/mobile.startup/util.js
+++ b/resources/mobile.startup/util.js
@@ -22,7 +22,7 @@
                },
                /**
                 * Return wgWikiBaseItemID config variable or 'wikidataid' 
query parameter if exits
-                * @returns {null|String}
+                * @return {null|String}
                 */
                getWikiBaseItemId: function () {
                        var id = mw.config.get( 'wgWikibaseItemId' ),
diff --git a/resources/mobile.toggle/toggle.js 
b/resources/mobile.toggle/toggle.js
index af892f7..2c409db 100644
--- a/resources/mobile.toggle/toggle.js
+++ b/resources/mobile.toggle/toggle.js
@@ -27,7 +27,7 @@
         *
         * @method
         * @param {Page} page
-        * @returns {Object} representing open sections
+        * @return {Object} representing open sections
         * @ignore
         */
        function getExpandedSections( page ) {
diff --git a/resources/mobile.user/user.js b/resources/mobile.user/user.js
index 477fde1..b45398e 100644
--- a/resources/mobile.user/user.js
+++ b/resources/mobile.user/user.js
@@ -18,7 +18,7 @@
                /**
                 * Find current users edit count
                 * @method
-                * @returns {Number} the edit count of the current user on the 
current wiki.
+                * @return {Number} the edit count of the current user on the 
current wiki.
                 */
                getEditCount: function () {
                        return mw.config.get( 'wgUserEditCount' );
diff --git a/resources/mobile.view/View.js b/resources/mobile.view/View.js
index 197f65d..fcf04a3 100644
--- a/resources/mobile.view/View.js
+++ b/resources/mobile.view/View.js
@@ -9,7 +9,7 @@
         * Useful for temporary DOM ids.
         * @ignore
         * @param {String} prefix Prefix to be used when generating the id.
-        * @returns {String}
+        * @return {String}
         */
        function uniqueId( prefix ) {
                var id = ( ++idCounter ).toString();
diff --git a/resources/mobile.watchlist/WatchListGateway.js 
b/resources/mobile.watchlist/WatchListGateway.js
index 16e1b77..ff8bb1a 100644
--- a/resources/mobile.watchlist/WatchListGateway.js
+++ b/resources/mobile.watchlist/WatchListGateway.js
@@ -31,7 +31,7 @@
        WatchListGateway.prototype = {
                /**
                 * Load the list of items on the watchlist
-                * @returns {jQuery.Deferred}
+                * @return {jQuery.Deferred}
                 */
                loadWatchlist: function () {
                        var self = this,
diff --git a/resources/skins.minerva.editor/init.js 
b/resources/skins.minerva.editor/init.js
index 32250f2..17894c4 100644
--- a/resources/skins.minerva.editor/init.js
+++ b/resources/skins.minerva.editor/init.js
@@ -48,7 +48,7 @@
         * @ignore
         * @param {Number} section number
         * @param {String} container CSS selector of the container
-        * @returns {jQuery.Object} newly created edit page button
+        * @return {jQuery.Object} newly created edit page button
         */
        function addEditButton( section, container ) {
                return $( '<a class="edit-page">' )
diff --git a/resources/skins.minerva.newusers/init.js 
b/resources/skins.minerva.newusers/init.js
index e3fd00f..f5b5138 100644
--- a/resources/skins.minerva.newusers/init.js
+++ b/resources/skins.minerva.newusers/init.js
@@ -21,7 +21,7 @@
        /**
         * Whether or not the user should see the leftNav guider
         * @ignore
-        * @returns {Boolean}
+        * @return {Boolean}
         */
        function shouldShowLeftNavEditTutorial() {
                return mw.util.getParamValue( 'campaign' ) === 'leftNavSignup' 
&&
@@ -31,7 +31,7 @@
        /**
         * If the user came from an edit button signup, show guider.
         * @ignore
-        * @returns {Boolean}
+        * @return {Boolean}
         */
        function shouldShowTutorial() {
                var shouldShowEditTutorial = mw.util.getParamValue( 
'article_action' ) === 'signup-edit' && !inEditor;
diff --git a/resources/skins.minerva.notifications/init.js 
b/resources/skins.minerva.notifications/init.js
index aa7a8bf..1cb2a12 100644
--- a/resources/skins.minerva.notifications/init.js
+++ b/resources/skins.minerva.notifications/init.js
@@ -15,7 +15,7 @@
         * @ignore
         * FIXME: Upstream to mw.mobileFrontend and reuse elsewhere
         * @param {String} moduleName Name of a module to fetch
-        * @returns {jQuery.Deferred}
+        * @return {jQuery.Deferred}
         */
        function loadModuleScript( moduleName ) {
                var d = $.Deferred(),
@@ -48,7 +48,7 @@
                 * @ignore
                 * @private
                 * @uses NotificationsOverlay
-                * @returns {jQuery.Deferred} with an instance of 
NotificationsOverlay
+                * @return {jQuery.Deferred} with an instance of 
NotificationsOverlay
                 */
                function loadNotificationOverlay() {
                        var result = $.Deferred();
diff --git a/resources/skins.minerva.scripts/init.js 
b/resources/skins.minerva.scripts/init.js
index 393dfc0..8012fba 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -65,7 +65,7 @@
         * Return the language code of the device in lowercase
         *
         * @ignore
-        * @returns {String|undefined}
+        * @return {String|undefined}
         */
        function getDeviceLanguage() {
                var lang = navigator && navigator.languages ?
@@ -82,7 +82,7 @@
         * @ignore
         * @uses ImageOverlay
         * @param {String} title Url of image
-        * @returns {jQuery.Deferred}
+        * @return {jQuery.Deferred}
         */
        function loadImageOverlay( title ) {
                var result = $.Deferred(),
diff --git a/resources/skins.minerva.scripts/mobileRedirect.js 
b/resources/skins.minerva.scripts/mobileRedirect.js
index a5b6800..cb62d26 100644
--- a/resources/skins.minerva.scripts/mobileRedirect.js
+++ b/resources/skins.minerva.scripts/mobileRedirect.js
@@ -15,7 +15,7 @@
         * If cookies are not enabled, show a toast and die.
         * @method
         * @ignore
-        * @returns {Boolean|undefined}
+        * @return {Boolean|undefined}
         */
        function desktopViewClick() {
                if ( !cookiesEnabled() ) {
diff --git a/resources/skins.minerva.scripts/references.js 
b/resources/skins.minerva.scripts/references.js
index d1261f7..40a0bbf 100644
--- a/resources/skins.minerva.scripts/references.js
+++ b/resources/skins.minerva.scripts/references.js
@@ -16,7 +16,7 @@
         * ReferenceGateway
         *
         * @ignore
-        * @returns {ReferencesDrawer}
+        * @return {ReferencesDrawer}
         */
        function referenceDrawerFactory() {
                var gateway = null;
diff --git a/tests/phpunit/MobileContextTest.php 
b/tests/phpunit/MobileContextTest.php
index ff0571f..c14ab48 100644
--- a/tests/phpunit/MobileContextTest.php
+++ b/tests/phpunit/MobileContextTest.php
@@ -9,7 +9,7 @@
         * protected and private methods directly through the Reflection API
         *
         * @param $name string
-        * @return \ReflectionMethod
+        * @return ReflectionMethod
         */
        protected static function getMethod( $name ) {
                $class = new ReflectionClass( 'MobileContext' );

-- 
To view, visit https://gerrit.wikimedia.org/r/321852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I427b22b13922dbb5620fe502675389ab3096601d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to