Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321881
Change subject: Fix minor PHPCS issues
......................................................................
Fix minor PHPCS issues
Change-Id: Ie5359fc80fca35aeadd4db958dca3910a5a77de8
---
M includes/ItemNotabilityFilter.php
M phpcs.xml
2 files changed, 5 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/81/321881/1
diff --git a/includes/ItemNotabilityFilter.php
b/includes/ItemNotabilityFilter.php
index 568bbe4..667c7e0 100644
--- a/includes/ItemNotabilityFilter.php
+++ b/includes/ItemNotabilityFilter.php
@@ -82,8 +82,8 @@
$itemIdSerialization = $itemId->getSerialization();
if (
$statementClaimsCount[$itemIdSerialization]['wb-claims'] >= self::MIN_STATEMENTS
- &&
$statementClaimsCount[$itemIdSerialization]['wb-sitelinks'] >=
self::MIN_SITELINKS ) {
-
+ &&
$statementClaimsCount[$itemIdSerialization]['wb-sitelinks'] >=
self::MIN_SITELINKS
+ ) {
$numericItemIds[] = $itemId->getNumericId();
}
}
diff --git a/phpcs.xml b/phpcs.xml
index b03ae21..df61672 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<ruleset name="ArticlePlaceholder">
<!-- See
https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/MediaWiki/ruleset.xml
-->
- <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<rule ref="Generic.ControlStructures" />
<rule ref="Generic.PHP.CharacterBeforePHPOpeningTag" />
@@ -35,7 +35,7 @@
</rule>
<file>.</file>
- <arg name="extensions" value="php,php5,inc"/>
- <arg name="encoding" value="utf8"/>
+ <arg name="extensions" value="php" />
+ <arg name="encoding" value="utf8" />
<exclude-pattern>vendor</exclude-pattern>
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/321881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5359fc80fca35aeadd4db958dca3910a5a77de8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
