jenkins-bot has submitted this change and it was merged.
Change subject: objectcache: Remove broken cas() method from WinCacheBagOStuff
......................................................................
objectcache: Remove broken cas() method from WinCacheBagOStuff
Bug: T120896
Change-Id: I9406a50df8e900b4fc5861c2174ba7a63a0dd765
(cherry picked from commit d1b53e32c7887ff0490aed1fdaeba0b93cd4bfeb)
---
M includes/libs/objectcache/WinCacheBagOStuff.php
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Reedy: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/libs/objectcache/WinCacheBagOStuff.php
b/includes/libs/objectcache/WinCacheBagOStuff.php
index 3d72abe..d512ad0 100644
--- a/includes/libs/objectcache/WinCacheBagOStuff.php
+++ b/includes/libs/objectcache/WinCacheBagOStuff.php
@@ -29,16 +29,7 @@
*/
class WinCacheBagOStuff extends BagOStuff {
protected function doGet( $key, $flags = 0 ) {
- $casToken = null;
-
- return $this->getWithToken( $key, $casToken, $flags );
- }
-
- protected function getWithToken( $key, &$casToken, $flags = 0 ) {
$val = wincache_ucache_get( $key );
-
- $casToken = $val;
-
if ( is_string( $val ) ) {
$val = unserialize( $val );
}
@@ -52,10 +43,6 @@
/* wincache_ucache_set returns an empty array on success if
$value
was an array, bool otherwise */
return ( is_array( $result ) && $result === [] ) || $result;
- }
-
- protected function cas( $casToken, $key, $value, $exptime = 0 ) {
- return wincache_ucache_cas( $key, $casToken, serialize( $value
) );
}
public function delete( $key ) {
--
To view, visit https://gerrit.wikimedia.org/r/321872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9406a50df8e900b4fc5861c2174ba7a63a0dd765
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
