Matthias Mullie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/322134

Change subject: Skip when there are no more uploads
......................................................................

Skip when there are no more uploads

An earlier patch removed part of the first `if`, causing
this else now not to be fired in conditions it originally
used to.

Change-Id: I369ee2677fe8741c019e87c34772563100336f22
---
M resources/controller/uw.controller.Details.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/34/322134/1

diff --git a/resources/controller/uw.controller.Details.js 
b/resources/controller/uw.controller.Details.js
index 2631a37..a7ff5bc 100644
--- a/resources/controller/uw.controller.Details.js
+++ b/resources/controller/uw.controller.Details.js
@@ -433,7 +433,9 @@
                // copy feature again
                if ( this.config.copyMetadataFeature ) {
                        this.addCopyMetadataFeature( this.uploads );
-               } else if ( this.uploads.length === 0 ) {
+               }
+
+               if ( this.uploads.length === 0 ) {
                        // If we have no more uploads, go to the "Upload" step. 
(This will go to "Thanks" step,
                        // which will skip itself in moveTo() because there are 
no uploads left.)
                        this.moveNext();

-- 
To view, visit https://gerrit.wikimedia.org/r/322134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I369ee2677fe8741c019e87c34772563100336f22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to