jenkins-bot has submitted this change and it was merged.
Change subject: BSApiTasksBase: Improved error handling
......................................................................
BSApiTasksBase: Improved error handling
If a subclass task implementation ends with
$this->dieUseage( 'Some message', 'some-message' );
the error code is being provided to the client.
Patch Set 3: Added setting the message property
Change-Id: I5319317ec7384118ce26cf2a2d5c8f6031105b21
---
M includes/api/BSApiTasksBase.php
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Mglaser: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/api/BSApiTasksBase.php b/includes/api/BSApiTasksBase.php
index b086c97..455ca7f 100644
--- a/includes/api/BSApiTasksBase.php
+++ b/includes/api/BSApiTasksBase.php
@@ -111,6 +111,11 @@
catch ( Exception $e ) {
$oResult->success = false;
$oResult->message =
$e->getMessage();
+ $mCode = method_exists( $e,
'getCodeString' ) ? $e->getCodeString() : $e->getCode();
+ if( $e instanceof DBError ) {
+ $mCode = 'dberror';
//TODO: error code for subtypes like DBQueryError or DBReadOnlyError?
+ }
+ $oResult->errors[$mCode] =
$e->getMessage();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/322271
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5319317ec7384118ce26cf2a2d5c8f6031105b21
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Dvogel hallowelt <[email protected]>
Gerrit-Reviewer: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
