Lokal Profil has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/322672

Change subject: Require site object only for older MediaWiki installations
......................................................................

Require site object only for older MediaWiki installations

The patch in Ifbc3fc0f324c7483f0eba092529a05a8f617ec8c introduced
the need for providing a Site object with WbQuantity to ensure
correct handling of missing error bounds. This affects anyone
working with Wikidata.

This patch changes the behaviour so that Wikidata users can continue
as before and Site objects are only needed for users of older
MediaWiki installations. It also ensures that Wikidata users do not
accidentally go on assuming +/-0 error bounds as default.

See T150210 for discussions.

Bug: T150210
Change-Id: I406db1e86dff772dae7af557859f1458ca87ba5d
---
M pywikibot/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/72/322672/1

diff --git a/pywikibot/__init__.py b/pywikibot/__init__.py
index 42b93ec..c588b2c 100644
--- a/pywikibot/__init__.py
+++ b/pywikibot/__init__.py
@@ -609,7 +609,7 @@
             warning(
                 "WbQuantity now expects a 'site' parameter. This is needed to "
                 "ensure correct handling of error bounds.")
-            return True
+            return False
         return MediaWikiVersion(site.version()) < 
MediaWikiVersion('1.29.0-wmf.2')
 
     @staticmethod

-- 
To view, visit https://gerrit.wikimedia.org/r/322672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I406db1e86dff772dae7af557859f1458ca87ba5d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Lokal Profil <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to