jenkins-bot has submitted this change and it was merged.

Change subject: Add second view tests for Firefox & IE
......................................................................


Add second view tests for Firefox & IE

We only test second view = cached content for Chrome today
and in that we we miss testing for the normal use case where
have content in local storage. Lets also test for FF & IE.

Bug: T151195
Change-Id: Ifd38bcd6c5fc5f27ae0f8bad22c41cfe9972e56f
---
M scripts/batch/second-view-desktop.txt
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/batch/second-view-desktop.txt 
b/scripts/batch/second-view-desktop.txt
index 10ece4f..014b4a7 100644
--- a/scripts/batch/second-view-desktop.txt
+++ b/scripts/batch/second-view-desktop.txt
@@ -12,3 +12,7 @@
 # $ WMF_WPT_KEY=SECRET_KEY STATSV_ENDPOINT=http://localhost WPT_RUNS=1 
WMF_WPT_LOCATION=us-west-1 bin/index.js --batch 
./scripts/scripts/second-view-desktop.txt
 
 --webPageTestKey <%WMF_WPT_KEY> --webPageTestHost wpt.wmftest.org --median 
SpeedIndex --location <%WMF_WPT_LOCATION>:Chrome --label chrome-second --runs 
<%WPT_RUNS> --first true --endpoint <%STATSV_ENDPOINT> --namespace 
webpagetest.enwiki.anonymous.Facebook-second --reporter statsv 
./scripts/wptscripts/second-view-desktop-enwiki-facebook.txt
+
+--webPageTestKey <%WMF_WPT_KEY> --webPageTestHost wpt.wmftest.org --median 
SpeedIndex --location <%WMF_WPT_LOCATION>:Firefox --label firefox-second --runs 
<%WPT_RUNS> --first true --endpoint <%STATSV_ENDPOINT> --namespace 
webpagetest.enwiki.anonymous.Facebook-second --reporter statsv 
./scripts/wptscripts/second-view-desktop-enwiki-facebook.txt
+
+--webPageTestKey <%WMF_WPT_KEY> --webPageTestHost wpt.wmftest.org --median 
SpeedIndex --location <%WMF_WPT_LOCATION>_IE11 --label ie-second --runs 
<%WPT_RUNS> --first true --endpoint <%STATSV_ENDPOINT> --namespace 
webpagetest.enwiki.anonymous.Facebook-second --reporter statsv 
./scripts/wptscripts/second-view-desktop-enwiki-facebook.txt

-- 
To view, visit https://gerrit.wikimedia.org/r/322641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd38bcd6c5fc5f27ae0f8bad22c41cfe9972e56f
Gerrit-PatchSet: 1
Gerrit-Project: performance/WebPageTest
Gerrit-Branch: master
Gerrit-Owner: Phedenskog <phedens...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to