jenkins-bot has submitted this change and it was merged. Change subject: Update incomplete JSDoc tags in suggesters ......................................................................
Update incomplete JSDoc tags in suggesters Change-Id: Ic969ba5c316460e2351f6c586681af3ea4cbbb6d --- M lib/jquery.ui/jquery.ui.commonssuggester.js M lib/jquery.ui/jquery.ui.languagesuggester.js M lib/jquery.ui/jquery.ui.unitsuggester.js 3 files changed, 14 insertions(+), 6 deletions(-) Approvals: Jonas Kress (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/lib/jquery.ui/jquery.ui.commonssuggester.js b/lib/jquery.ui/jquery.ui.commonssuggester.js index 2720637..190c7c0 100644 --- a/lib/jquery.ui/jquery.ui.commonssuggester.js +++ b/lib/jquery.ui/jquery.ui.commonssuggester.js @@ -87,8 +87,12 @@ }, /** - * @inheritdoc + * @see jQuery.ui.suggester._createMenuItemFromSuggestion * @protected + * + * @param {string} suggestion + * @param {string} requestTerm + * @return {jQuery.ui.ooMenu.Item} */ _createMenuItemFromSuggestion: function( suggestion, requestTerm ) { suggestion = suggestion.replace( /^File:/, '' ); diff --git a/lib/jquery.ui/jquery.ui.languagesuggester.js b/lib/jquery.ui/jquery.ui.languagesuggester.js index 4ebb408..3f28b3a 100644 --- a/lib/jquery.ui/jquery.ui.languagesuggester.js +++ b/lib/jquery.ui/jquery.ui.languagesuggester.js @@ -86,6 +86,7 @@ /** * Instantiates a menu item instance from a suggestion. + * @see jQuery.ui.suggester._createMenuItemFromSuggestion * @protected * * @param {Object} suggestion diff --git a/lib/jquery.ui/jquery.ui.unitsuggester.js b/lib/jquery.ui/jquery.ui.unitsuggester.js index 3a75837..bee4085 100644 --- a/lib/jquery.ui/jquery.ui.unitsuggester.js +++ b/lib/jquery.ui/jquery.ui.unitsuggester.js @@ -226,15 +226,18 @@ }, /** - * @inheritdoc + * @see jQuery.ui.suggester._createMenuItemFromSuggestion * @protected + * + * @param {Object} entityStub + * @return {jQuery.ui.ooMenu.Item} */ - _createMenuItemFromSuggestion: function( suggestion ) { - var $label = this._createLabelFromSuggestion( suggestion ), - value = suggestion.label || suggestion.id; + _createMenuItemFromSuggestion: function( entityStub ) { + var $label = this._createLabelFromSuggestion( entityStub ), + value = entityStub.label || entityStub.id; var item = new $.ui.ooMenu.Item( $label, value ); - item._link = suggestion.concepturi || suggestion.url; + item._link = entityStub.concepturi || entityStub.url; return item; }, -- To view, visit https://gerrit.wikimedia.org/r/316937 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic969ba5c316460e2351f6c586681af3ea4cbbb6d Gerrit-PatchSet: 1 Gerrit-Project: data-values/value-view Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits