Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322741
Change subject: Update: lower contrast of list item overflow buttons
......................................................................
Update: lower contrast of list item overflow buttons
Bug: T144858
Change-Id: Iae3af08b6bb98638f45345ebe48994eb1d4e8f0a
---
M app/src/main/res/layout/view_list_card_item.xml
M app/src/main/res/values/attrs.xml
M app/src/main/res/values/colors.xml
M app/src/main/res/values/styles_dark.xml
M app/src/main/res/values/styles_light.xml
5 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/41/322741/1
diff --git a/app/src/main/res/layout/view_list_card_item.xml
b/app/src/main/res/layout/view_list_card_item.xml
index 5d30c2e..0ab2eea 100644
--- a/app/src/main/res/layout/view_list_card_item.xml
+++ b/app/src/main/res/layout/view_list_card_item.xml
@@ -63,7 +63,8 @@
android:layout_gravity="end"
android:padding="8dp"
app:srcCompat="@drawable/ic_more_vert_white_24dp"
- android:tint="?attr/feed_text_tertiary_color"
+ android:tint="?attr/overflow_button"
+ android:tintMode="src_in"
android:background="?attr/selectableItemBackgroundBorderless"
android:contentDescription="@null"/>
diff --git a/app/src/main/res/values/attrs.xml
b/app/src/main/res/values/attrs.xml
index 9be1fac..e0f9b64 100644
--- a/app/src/main/res/values/attrs.xml
+++ b/app/src/main/res/values/attrs.xml
@@ -35,6 +35,7 @@
<attr name="feed_text_secondary_color" format="reference" />
<attr name="feed_text_tertiary_color" format="reference" />
<attr name="nav_tab_background_color" format="reference" />
+ <attr name="overflow_button" format="reference" />
<declare-styleable name="CabSearchView">
<attr name="cabEnabled" format="boolean" />
diff --git a/app/src/main/res/values/colors.xml
b/app/src/main/res/values/colors.xml
index cb5b158..192cf10 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -28,6 +28,8 @@
<color name="main_toolbar">@color/foundation_blue</color>
<color name="nav_border">#505050</color>
<color name="actionbar_disabled">#a0a0a0</color>
+ <color name="light_gray_overflow_button">#42000000</color>
+ <color name="dark_gray_overflow_button">#42ffffff</color>
<color name="button_disabled">#bebebe</color>
<color name="preview_header_background">#d0d0d0</color>
<color name="white_progressive_dark">#f0f0f0</color>
diff --git a/app/src/main/res/values/styles_dark.xml
b/app/src/main/res/values/styles_dark.xml
index 2343c1d..a1ad2ca 100644
--- a/app/src/main/res/values/styles_dark.xml
+++ b/app/src/main/res/values/styles_dark.xml
@@ -56,6 +56,7 @@
<item
name="list_item_text_primary_color">@color/list_item_text_primary_dark</item>
<item
name="list_item_text_secondary_color">@color/list_item_text_secondary_dark</item>
<item name="nav_tab_background_color">@color/darkest_gray</item>
+ <item name="overflow_button">@color/dark_gray_overflow_button</item>
<!-- TODO: move to AppTheme when style hierarchy is corrected. -->
<item name="android:listViewStyle">@style/ListView</item>
diff --git a/app/src/main/res/values/styles_light.xml
b/app/src/main/res/values/styles_light.xml
index bae53e8..da0154c 100644
--- a/app/src/main/res/values/styles_light.xml
+++ b/app/src/main/res/values/styles_light.xml
@@ -58,6 +58,7 @@
<item
name="list_item_text_primary_color">@color/list_item_text_primary_light</item>
<item
name="list_item_text_secondary_color">@color/list_item_text_secondary_light</item>
<item name="nav_tab_background_color">@android:color/white</item>
+ <item name="overflow_button">@color/light_gray_overflow_button</item>
<!-- TODO: move to AppTheme when style hierarchy is corrected. -->
<item name="android:listViewStyle">@style/ListView</item>
--
To view, visit https://gerrit.wikimedia.org/r/322741
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae3af08b6bb98638f45345ebe48994eb1d4e8f0a
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
