jenkins-bot has submitted this change and it was merged.
Change subject: Don't show icon on talk button
......................................................................
Don't show icon on talk button
Bug: T142976
Change-Id: Iaa531b15855d6489cb49e18fd1ec99427789065c
---
M includes/skins/SkinMinerva.php
M includes/skins/SkinMinervaBeta.php
2 files changed, 1 insertion(+), 13 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
Objections:
Phuedx: There's a problem with this change, please improve
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index b44ed65..d051451 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -926,7 +926,7 @@
'attributes' => [
'href' => $talkTitle->getLinkURL(),
'data-title' => $talkTitle->getFullText(),
- 'class' => MobileUI::iconClass( 'talk',
'before', 'talk' ),
+ 'class' => 'talk',
],
'label' => $talkButton['text'],
];
diff --git a/includes/skins/SkinMinervaBeta.php
b/includes/skins/SkinMinervaBeta.php
index 4c9fc26..1782962 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -45,16 +45,4 @@
return $modules;
}
-
- /**
- * Get the needed styles for this skin
- * @return array
- */
- protected function getSkinStyles() {
- $title = $this->getTitle();
- $styles = parent::getSkinStyles();
- $styles[] = 'skins.minerva.icons.images.variants';
-
- return $styles;
- }
}
--
To view, visit https://gerrit.wikimedia.org/r/321692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa531b15855d6489cb49e18fd1ec99427789065c
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
