jenkins-bot has submitted this change and it was merged.
Change subject: Exception renderer: Remove useless check for isCommandLine()
......................................................................
Exception renderer: Remove useless check for isCommandLine()
If we're on the cli, we would've never hit this else block
Change-Id: Idff009ab255b1907f752e0c6b5652715923b0ed7
---
M includes/exception/MWExceptionRenderer.php
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Reedy: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/exception/MWExceptionRenderer.php
b/includes/exception/MWExceptionRenderer.php
index 8fdc417..f713115 100644
--- a/includes/exception/MWExceptionRenderer.php
+++ b/includes/exception/MWExceptionRenderer.php
@@ -74,11 +74,7 @@
$message =
MWExceptionHandler::getPublicLogMessage( $e );
}
}
- if ( self::isCommandLine() ) {
- self::printError( $message );
- } else {
- echo nl2br( htmlspecialchars( $message ) ) .
"\n";
- }
+ echo nl2br( htmlspecialchars( $message ) ) . "\n";
}
}
--
To view, visit https://gerrit.wikimedia.org/r/322771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idff009ab255b1907f752e0c6b5652715923b0ed7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
