Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/322813
Change subject: vector.js: Replace deprecated jQuery bind() with on() ...................................................................... vector.js: Replace deprecated jQuery bind() with on() > JQMIGRATE: jQuery.fn.bind() is deprecated Note that bind() is not removed in v3, merely deprecated. Even after the jQuery Migrate phase, it will continue to work. https://jquery.com/upgrade-guide/3.0/ Ref I3c3dedaa. Bug: T124742 Change-Id: I6bbd8f829ecf987228c6a5abd32c84e4e088a9bd --- M vector.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector refs/changes/13/322813/1 diff --git a/vector.js b/vector.js index 5842701..e823f8d 100644 --- a/vector.js +++ b/vector.js @@ -54,7 +54,7 @@ // Bind callback functions to animate our drop down menu in and out // and then call the collapsibleTabs function on the menu $tabContainer - .bind( 'beforeTabCollapse', function () { + .on( 'beforeTabCollapse', function () { // If the dropdown was hidden, show it if ( $cactions.hasClass( 'emptyPortlet' ) ) { $cactions @@ -63,7 +63,7 @@ .css( 'width', '1px' ).animate( { width: initialCactionsWidth() }, 'normal' ); } } ) - .bind( 'beforeTabExpand', function () { + .on( 'beforeTabExpand', function () { // If we're removing the last child node right now, hide the dropdown if ( $cactions.find( 'li' ).length === 1 ) { $cactions.find( 'h3' ).animate( { width: '1px' }, 'normal', function () { -- To view, visit https://gerrit.wikimedia.org/r/322813 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6bbd8f829ecf987228c6a5abd32c84e4e088a9bd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/Vector Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
