jenkins-bot has submitted this change and it was merged.
Change subject: mw.Upload.BookletLayout: Improve error message when not all
logged-in users can upload
......................................................................
mw.Upload.BookletLayout: Improve error message when not all logged-in users can
upload
Bug: T139257
Change-Id: I0ba4d0deba68d76bbcb01ee2202f82d392a68107
---
M resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Prtksxna: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
index 100714a..c7ebfd8 100644
--- a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
+++ b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
@@ -187,8 +187,11 @@
// If the user can't upload anything,
don't give them the option to.
api.getUserInfo().then( function (
userInfo ) {
if ( userInfo.rights.indexOf(
'upload' ) === -1 ) {
- // TODO Use a better
error message when not all logged-in users can upload
- booklet.getPage(
'upload' ).$element.msg( 'api-error-mustbeloggedin' );
+ if ( mw.user.isAnon() )
{
+
booklet.getPage( 'upload' ).$element.msg( 'api-error-mustbeloggedin' );
+ } else {
+
booklet.getPage( 'upload' ).$element.msg( 'api-error-badaccess-groups' );
+ }
}
return $.Deferred().resolve();
} )
--
To view, visit https://gerrit.wikimedia.org/r/322652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ba4d0deba68d76bbcb01ee2202f82d392a68107
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
