Mobrovac has submitted this change and it was merged.
Change subject: Ignore articles outside the main namespace
......................................................................
Ignore articles outside the main namespace
Bug: T145554
Change-Id: I006ac1daf3b124dec1dce36e0d5796f9e8013114
---
M lib/processor.js
M test/features/lib/processor.js
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Mobrovac: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/processor.js b/lib/processor.js
index 947fb37..5966514 100644
--- a/lib/processor.js
+++ b/lib/processor.js
@@ -16,11 +16,10 @@
* @param {Object} edit
*/
function process(edit) {
- var page;
var id = edit.page_id;
var ts = edit.rev_timestamp;
- if (edit.meta.topic === 'mediawiki.revision-create') {
+ if (edit.meta.topic === 'mediawiki.revision-create' && edit.page_namespace
=== 0) {
if (pages[id]) {
pages[id].edits++;
pages[id].updated = ts;
diff --git a/test/features/lib/processor.js b/test/features/lib/processor.js
index 15e461f..affc818 100644
--- a/test/features/lib/processor.js
+++ b/test/features/lib/processor.js
@@ -27,8 +27,9 @@
processor.process( edit( 1, 'Jon', '2016-11-15T18:00:55+00:00' ) );
processor.process( edit( 1, 'Corey', '2016-11-15T18:02:55+00:00' ) );
processor.process( edit( 1, 'Bernd', '2016-11-15T18:03:55+00:00' ) );
+ processor.process( edit( 2, 'Talker', '2016-11-15T18:03:55+00:00', 1 ) );
- it('check events are combined', function() {
+ it('check events are combined for articles in main namespace', function() {
var pages = processor.getPages();
assert.ok( pages.length === 1, 'Pages with same name are combined into
single page' );
assert.ok( pages[0].edits === 3, 'Edits are counted' );
--
To view, visit https://gerrit.wikimedia.org/r/322784
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I006ac1daf3b124dec1dce36e0d5796f9e8013114
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
