Mobrovac has submitted this change and it was merged.
Change subject: Describe delete behaviour
......................................................................
Describe delete behaviour
Bug: T145554
Change-Id: Ia711f3290e7331f4b9252289d964fa69d437e71e
---
M lib/processor.js
M test/features/lib/processor.js
2 files changed, 18 insertions(+), 1 deletion(-)
Approvals:
Mobrovac: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/processor.js b/lib/processor.js
index a493068..d3ae59d 100644
--- a/lib/processor.js
+++ b/lib/processor.js
@@ -22,7 +22,9 @@
var isAnon = edit.performer.user_id === undefined;
var topic = edit.meta.topic;
- if (topic === 'mediawiki.page-move' && pages[id]) {
+ if (topic === 'mediawiki.page-delete') {
+ delete pages[id];
+ } else if (topic === 'mediawiki.page-move' && pages[id]) {
pages[id].title = edit.page_title;
// assumption here made that anons cannot move pages so we do not
touch anonEdits
pages[id].edits -= 1;
diff --git a/test/features/lib/processor.js b/test/features/lib/processor.js
index 78d5070..4e4b4e0 100644
--- a/test/features/lib/processor.js
+++ b/test/features/lib/processor.js
@@ -31,6 +31,12 @@
page_is_redirect: true
};
+const PAGE_DELETE_EVENT = {
+ meta: { topic: "mediawiki.page-delete" },
+ performer: ADMIN,
+ page_id: 3
+};
+
function edit( id, username, ts, ns, isBot ) {
var performer = {
user_groups: ["*"],
@@ -113,6 +119,15 @@
var pages = processor.getPages();
assert.ok( pages.length === 1, 'In a move the redirect is ignored.' );
});
+
+ it('A deleted page gets removed from the store', function() {
+ processor.reset();
+ processor.process( edit( 3, 'Jon', '2016-11-15T18:00:55+00:00' ) );
+ processor.process( PAGE_DELETE_EVENT );
+
+ var pages = processor.getPages();
+ assert.ok( pages.length === 0, 'The store is empty.' );
+ });
});
describe('processor - initial state', function() {
--
To view, visit https://gerrit.wikimedia.org/r/323043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia711f3290e7331f4b9252289d964fa69d437e71e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
