jenkins-bot has submitted this change and it was merged.
Change subject: BSReview: Added Reload of BsReviewProcess after update db row
......................................................................
BSReview: Added Reload of BsReviewProcess after update db row
* The BsReviewProcess was never considered ->finished(). This Propably fixes a
ton of known bugs like "No mail after workflow finish"
=> NEEDS Cherry-Pick to REL1_27 and REL1_23
Change-Id: I713fede2568ed037a236e4f51caa8f3adb00810e
---
M Review/Review.class.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Review/Review.class.php b/Review/Review.class.php
index f245e40..2b7eab4 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1306,6 +1306,10 @@
$dbw->update( 'bs_review_steps', $data, array( 'revs_id' =>
$step_id ) );
$oTitle->invalidateCache();
+ //RELOAD ReviewProcess!
+ $oReviewProcess = BsReviewProcess::newFromPid(
+ (int) $oTitle->getArticleID()
+ );
if ( $sVote == 'no' ) {
if ( $oReviewProcess->isSequential() ) {
--
To view, visit https://gerrit.wikimedia.org/r/323415
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I713fede2568ed037a236e4f51caa8f3adb00810e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
