jenkins-bot has submitted this change and it was merged.
Change subject: Fix undefined $htmlDiff
......................................................................
Fix undefined $htmlDiff
Bug: T138813
Change-Id: Id775345955c480f0cb2e4d0eb695c303372e0ccb
(cherry picked from commit dc5e5f8fb1bf4dfed25a57b097c2b8135c682e58)
---
M MassEditRegex.special.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Kghbln: Looks good to me, but someone else must approve
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MassEditRegex.special.php b/MassEditRegex.special.php
index 157b403..d8b9a6b 100644
--- a/MassEditRegex.special.php
+++ b/MassEditRegex.special.php
@@ -54,9 +54,10 @@
$pageCountLimit = $isPreview ? MER_MAX_PREVIEW_DIFFS :
MER_MAX_EXECUTE_PAGES;
$errors = array();
+ $htmlDiff = '';
+
if ( $isPreview ) {
$this->massEditRegex->getDiffEngine()->showDiffStyle();
- $htmlDiff = '';
} else {
$wgOut->addHTML( '<ul>' );
}
--
To view, visit https://gerrit.wikimedia.org/r/316326
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id775345955c480f0cb2e4d0eb695c303372e0ccb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassEditRegex
Gerrit-Branch: REL1_27
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: 20after4 <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Kghbln <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
