Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/323496

Change subject: Minor redesign
......................................................................

Minor redesign

* Fix logo alignment (was not centered in the sidebar space).
* Fix lack of spacing above header text (.header h2)
* Make space even in the search form (previously too much due to
  padding and first-paragraph margin adding up).
* Move footer outside content area.
* Add links to 'Issue tracker' and 'Source repository'.

Change-Id: I91083326762673ea03a572fa49b22a95ee2538bf
---
M index.php
M resources/style.css
2 files changed, 33 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/tools/guc 
refs/changes/96/323496/1

diff --git a/index.php b/index.php
index 499558f..20ee570 100644
--- a/index.php
+++ b/index.php
@@ -184,9 +184,11 @@
             // $app->printTimes();
             // print '</pre>';
             ?>
-            <div class="footer">
-                by <a 
href="https://wikitech.wikimedia.org/wiki/User:Luxo";>Luxo</a> &bull; <a 
href="https://meta.wikimedia.org/wiki/User:Krinkle";>Krinkle</a>
-            </div>
+        </div>
+        <div class="footer">
+            by <a 
href="https://wikitech.wikimedia.org/wiki/User:Luxo";>Luxo</a> · <a 
href="https://meta.wikimedia.org/wiki/User:Krinkle";>Krinkle</a>
+            <br>
+            <a href="https://github.com/wikimedia/labs-tools-guc";>Source 
repository</a> · <a href="https://phabricator.wikimedia.org/tag/guc/";>Issue 
tracker</a>
         </div>
         <script src="resources/frontend.js"></script>
     </body>
diff --git a/resources/style.css b/resources/style.css
index e624576..60fdd5d 100644
--- a/resources/style.css
+++ b/resources/style.css
@@ -6,26 +6,32 @@
 */
 
 body {
+    margin: 0;
+    padding: 0;
+    color: #333;
     font-family: sans-serif, arial;
     font-size: 13px;
     font-weight: 400;
     line-height: 19px;
     direction: ltr;
-    background: url(//tools.wmflabs.org/Tool_Labs_logo_thumb.png) no-repeat 
scroll 10px 10px;
-    padding: 0;
-    margin: 0;
+    /* 150px sidebar width - 122px logo width = 28px spacing = 14px from left 
*/
+    background: #f8f8f8 url(//tools.wmflabs.org/Tool_Labs_logo_thumb.png) 
no-repeat scroll 14px 14px;
 }
 
+a {
+    text-decoration: none;
+    color: #0645ad;
+}
+a:active { text-decoration: none; }
+a:hover { text-decoration: underline; }
+
 .maincontent {
-    position: relative;
-    margin-left: 150px;
-    top: 50px;
-    border-top: 1px solid grey;
-    border-left: 1px solid grey;
-    border-bottom: 1px solid grey;
+    margin: 50px 0 0 150px;
+    border: 1px solid #e7e7e7;
+    border-right: 0;
     border-top-left-radius: 5px;
     padding: 10px;
-    background-color: rgba(250,250,250,255);
+    background-color: #fff;
 }
 .maincontent .box {
     display: inline-block;
@@ -42,47 +48,43 @@
     color: #cc0000;
 }
 
-.maincontent .header h2{
-    margin: 0;
+.maincontent .header h2 {
+    margin: 10px 0 15px 0;
     font-size: 25px;
     font-weight: 400;
-    margin-bottom: 15px;
 }
 .maincontent .header h2 span {
     color: red;
     font-size: 15px;
 }
 
-.maincontent .footer {
+.footer {
+    margin: 25px 0 0 150px;
     text-align: center;
-    margin-top: 50px;
+    color: #777;
 }
 
 .maincontent .searchField {
-    border: 1px solid grey;
-    padding: 10px;
-    -webkit-border-radius: 5px;
-    -moz-border-radius: 5px;
+    border: 1px solid #e5e5e5;
+    padding: 0 10px 10px 10px;
     border-radius: 5px;
+    background: #f8f8f8;
 }
 
-.maincontent .results a { text-decoration: none; color: #0645AD; }
-.maincontent .results a:active { text-decoration: none; }
-.maincontent .results a:hover  { text-decoration: underline; }
 .maincontent .results a:visited { color: #5105ad; }
 .maincontent .results .hostname {
     background-image: url(img/icoInfo16.png);
     background-repeat: no-repeat;
     padding-left: 21px;
 }
-.maincontent h1,
-.maincontent h2 {
+ .results h1,
+ .results h2 {
     font-size: 20px;
     font-weight: 700;
     border-bottom: 1px solid grey;
     margin-bottom: 2px;
 }
-.maincontent h2 {
+ .results h2 {
     font-size: 15px;
 }
 
@@ -91,7 +93,7 @@
 }
 
 .maincontent .results .wiki .wikiinfo {
-    color: #7D7D7D;
+    color: #777;
     font-size: 84%;
     margin-top: 0;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/323496
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91083326762673ea03a572fa49b22a95ee2538bf
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/guc
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to