Faidon Liambotis has submitted this change and it was merged.
Change subject: Remove cron notifications to root@ for jobchron/runner service
status
......................................................................
Remove cron notifications to root@ for jobchron/runner service status
Bug: T132324
Change-Id: I325403be1d0b786ace3518bdb574cf711322c3d4
---
M modules/mediawiki/templates/jobrunner/logrotate-jobchron.conf.erb
M modules/mediawiki/templates/jobrunner/logrotate.conf.erb
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Faidon Liambotis: Looks good to me, approved
Volans: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/mediawiki/templates/jobrunner/logrotate-jobchron.conf.erb
b/modules/mediawiki/templates/jobrunner/logrotate-jobchron.conf.erb
index 43982fb..d3b6970 100644
--- a/modules/mediawiki/templates/jobrunner/logrotate-jobchron.conf.erb
+++ b/modules/mediawiki/templates/jobrunner/logrotate-jobchron.conf.erb
@@ -11,7 +11,7 @@
nocreate
postrotate
<%- if scope.lookupvar('::initsystem') == 'systemd' -%>
- if /bin/systemctl is-active jobchron.service; then
+ if /bin/systemctl -q is-active jobchron.service; then
/bin/systemctl restart jobchron.service
fi
<%- else -%>
diff --git a/modules/mediawiki/templates/jobrunner/logrotate.conf.erb
b/modules/mediawiki/templates/jobrunner/logrotate.conf.erb
index 4c99e75..201cbc3 100644
--- a/modules/mediawiki/templates/jobrunner/logrotate.conf.erb
+++ b/modules/mediawiki/templates/jobrunner/logrotate.conf.erb
@@ -10,7 +10,7 @@
nocreate
postrotate
<%- if scope.lookupvar('::initsystem') == 'systemd' -%>
- if /bin/systemctl is-active jobrunner.service; then
+ if /bin/systemctl -q is-active jobrunner.service; then
/bin/systemctl restart jobrunner.service
fi
<%- else -%>
--
To view, visit https://gerrit.wikimedia.org/r/323528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I325403be1d0b786ace3518bdb574cf711322c3d4
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Volans <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits