jenkins-bot has submitted this change and it was merged.
Change subject: Fix labels on diff dialog
......................................................................
Fix labels on diff dialog
Change-Id: I421d229a4c3d01db0309268923a876d20eb03da4
---
M demos/ve/ve.demo.SurfaceContainer.js
M src/ui/dialogs/ve.ui.DiffDialog.js
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/ve/ve.demo.SurfaceContainer.js
b/demos/ve/ve.demo.SurfaceContainer.js
index fa44307..2dd3924 100644
--- a/demos/ve/ve.demo.SurfaceContainer.js
+++ b/demos/ve/ve.demo.SurfaceContainer.js
@@ -40,7 +40,7 @@
label: 'Save HTML'
} );
diffButton = new OO.ui.ButtonWidget( {
- label: 'Get diff'
+ label: 'Show changes'
} );
$exitReadButton = $( '<a href="#">' ).text( 'Back to editor' ).on(
'click', function () {
container.change( 've' );
diff --git a/src/ui/dialogs/ve.ui.DiffDialog.js
b/src/ui/dialogs/ve.ui.DiffDialog.js
index 65daa89..b4024e7 100644
--- a/src/ui/dialogs/ve.ui.DiffDialog.js
+++ b/src/ui/dialogs/ve.ui.DiffDialog.js
@@ -28,10 +28,13 @@
ve.ui.DiffDialog.static.size = 'larger';
-ve.ui.DiffDialog.static.title = 'Diff dialog';
+ve.ui.DiffDialog.static.title = 'Changes';
ve.ui.DiffDialog.static.actions = [
- { label: 'Cancel', flags: 'safe' }
+ {
+ label: OO.ui.deferMsg( 'visualeditor-dialog-action-done' ),
+ flags: 'safe'
+ }
];
/* Methods */
--
To view, visit https://gerrit.wikimedia.org/r/323535
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I421d229a4c3d01db0309268923a876d20eb03da4
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
