jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: light FeedCoordinator refactoring
......................................................................
Hygiene: light FeedCoordinator refactoring
* Tighten up class access
* Remove init() method and inline the single method call it contained
* Remove unnecessary comment
Change-Id: Ica9c6fee1d031f868a7faf7237427e1e6f77bfad
---
M app/src/main/java/org/wikipedia/feed/FeedCoordinator.java
1 file changed, 3 insertions(+), 10 deletions(-)
Approvals:
jenkins-bot: Verified
Niedzielski: Looks good to me, approved
diff --git a/app/src/main/java/org/wikipedia/feed/FeedCoordinator.java
b/app/src/main/java/org/wikipedia/feed/FeedCoordinator.java
index 01f34b2..251f297 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedCoordinator.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedCoordinator.java
@@ -10,20 +10,17 @@
import org.wikipedia.feed.random.RandomClient;
import org.wikipedia.feed.searchbar.SearchClient;
-public class FeedCoordinator extends FeedCoordinatorBase {
+class FeedCoordinator extends FeedCoordinatorBase {
- public FeedCoordinator(@NonNull Context context) {
+ FeedCoordinator(@NonNull Context context) {
super(context);
}
@Override
protected void buildScript(int age) {
-
- // hard-coded list of card types to load when continuing the feed
if (age == 0) {
- init();
+ addPendingClient(new SearchClient());
}
-
addPendingClient(new AggregatedFeedContentClient());
addPendingClient(new ContinueReadingClient());
if (age == 0) {
@@ -33,9 +30,5 @@
if (age == 0) {
addPendingClient(new RandomClient());
}
- }
-
- private void init() {
- addPendingClient(new SearchClient());
}
}
--
To view, visit https://gerrit.wikimedia.org/r/323894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica9c6fee1d031f868a7faf7237427e1e6f77bfad
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
