Krinkle has submitted this change and it was merged.
Change subject: Fixing Inject to not create empty tags
......................................................................
Fixing Inject to not create empty tags
Using the Inject functionality with the builders section caused
an error in Jenkins because the script-file was blank but the tag
existed in the xml.
Fixing this by adding a function to create the XML only if the given
value is not None and not a blank value '':
def add_nonblank_xml_subelement(parent, tag, value):
Change-Id: I9151f7444f6807e929721b04fb8e7ad3a867cd6c
Reviewed-on: https://review.openstack.org/18820
Reviewed-by: Jon-Paul Sullivan <[email protected]>
Reviewed-by: Tollef Fog Heen <[email protected]>
Reviewed-by: Jeremy Stanley <[email protected]>
Approved: Monty Taylor <[email protected]>
Reviewed-by: Monty Taylor <[email protected]>
Tested-by: Jenkins
---
M jenkins_jobs/modules/base.py
M jenkins_jobs/modules/builders.py
M jenkins_jobs/modules/properties.py
M jenkins_jobs/modules/wrappers.py
4 files changed, 39 insertions(+), 27 deletions(-)
--
To view, visit https://gerrit.wikimedia.org/r/48880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9151f7444f6807e929721b04fb8e7ad3a867cd6c
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
