jenkins-bot has submitted this change and it was merged.
Change subject: Make sure project name is set and not an empty string
......................................................................
Make sure project name is set and not an empty string
Change-Id: I9209e75e8486d32ea339aadbe0354fd93132e584
---
M PageAssessmentsBody.php
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Niharika29: Looks good to me, approved
jenkins-bot: Verified
diff --git a/PageAssessmentsBody.php b/PageAssessmentsBody.php
index cc19ce8..baba514 100644
--- a/PageAssessmentsBody.php
+++ b/PageAssessmentsBody.php
@@ -46,12 +46,14 @@
// Compile a list of projects to find out which ones to be
deleted afterwards
$projects = array();
foreach ( $assessmentData as $parserData ) {
- // For each project, get the corresponding ID from
page_assessments_projects table
- $projectId = self::getProjectId( $parserData[0] );
- if ( $projectId === false ) {
- $projectId = self::insertProject(
$parserData[0] );
+ if ( isset( $parserData[0] ) && $parserData[0] !== '' )
{
+ // For each project, get the corresponding ID
from page_assessments_projects table
+ $projectId = self::getProjectId( $parserData[0]
);
+ if ( $projectId === false ) {
+ $projectId = self::insertProject(
$parserData[0] );
+ }
+ $projects[$parserData[0]] = $projectId;
}
- $projects[$parserData[0]] = $projectId;
}
$projectsInDb = self::getAllProjects( $pageId,
self::READ_LATEST );
$toInsert = array_diff( $projects, $projectsInDb );
--
To view, visit https://gerrit.wikimedia.org/r/323983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9209e75e8486d32ea339aadbe0354fd93132e584
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: Niharika29 <nihar...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
