Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/324415
Change subject: Refactor ve.dm.Transaction ...................................................................... Refactor ve.dm.Transaction * Create ve.dm.TransactionBuilder; put ve.dm.Transaction-building code there * Put rebasing code into ve.dm.Change * Add simple non-validating methods that clearly show possible operations * Make ve.dm.Transaction into an OOjs class In a future commit, ve.dm.TransactionBuilder should be refactored further; it's currently structured to have a small diff against the old ve.dm.Transaction.js file. The same goes for various unit tests that create transactions. Change-Id: I61fcb3b1b766667da37410f415466ffee7835aeb --- M .jsduck/categories.json M build/modules.json M demos/ve/desktop.html M demos/ve/mobile.html M src/ce/keydownhandlers/ve.ce.LinearEnterKeyDownHandler.js M src/ce/nodes/ve.ce.TableRowNode.js M src/ce/ve.ce.Surface.js M src/ce/ve.ce.TextState.js M src/ce/ve.ce.js M src/dm/ve.dm.Change.js M src/dm/ve.dm.InternalList.js M src/dm/ve.dm.MetaList.js M src/dm/ve.dm.Node.js M src/dm/ve.dm.SurfaceFragment.js M src/dm/ve.dm.Transaction.js A src/dm/ve.dm.TransactionBuilder.js M src/ui/actions/ve.ui.IndentationAction.js M src/ui/actions/ve.ui.TableAction.js M src/ui/elements/ve.ui.DiffElement.js M tests/dm/ve.dm.Change.test.js M tests/dm/ve.dm.Document.test.js M tests/dm/ve.dm.MetaList.test.js M tests/dm/ve.dm.Surface.test.js M tests/dm/ve.dm.Transaction.test.js A tests/dm/ve.dm.TransactionBuilder.test.js M tests/dm/ve.dm.TransactionProcessor.test.js M tests/index.html 27 files changed, 4,014 insertions(+), 3,921 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/15/324415/1 -- To view, visit https://gerrit.wikimedia.org/r/324415 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61fcb3b1b766667da37410f415466ffee7835aeb Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Divec <da...@troi.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits