ArielGlenn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324678

Change subject: make sure db_user and db_password config attributes are 
initialized
......................................................................

make sure db_user and db_password config attributes are initialized

Change-Id: I6e9fba888f61760f26b2d3ad4a1bf56df58c7366
---
M xmldumps-backup/dumps/WikiDump.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/dumps 
refs/changes/78/324678/1

diff --git a/xmldumps-backup/dumps/WikiDump.py 
b/xmldumps-backup/dumps/WikiDump.py
index 9e067cd..8c7c9c6 100644
--- a/xmldumps-backup/dumps/WikiDump.py
+++ b/xmldumps-backup/dumps/WikiDump.py
@@ -271,9 +271,13 @@
         dbuser = self.get_opt_for_proj_or_default(conf, "database", "user", 0)
         if dbuser:
             self.db_user = dbuser
+        else:
+            self.db_user = None
         dbpassword = self.get_opt_for_proj_or_default(conf, "database", 
"password", 0)
         if dbpassword:
             self.db_password = dbpassword
+        else:
+            self.db_user = None
         max_allowed_packet = self.get_opt_for_proj_or_default(
             conf, "database", "max_allowed_packet", 0)
         if max_allowed_packet:

-- 
To view, visit https://gerrit.wikimedia.org/r/324678
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e9fba888f61760f26b2d3ad4a1bf56df58c7366
Gerrit-PatchSet: 1
Gerrit-Project: operations/dumps
Gerrit-Branch: master
Gerrit-Owner: ArielGlenn <ar...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to