jenkins-bot has submitted this change and it was merged.

Change subject: Make Special:EntityUsage and Special:PagesWithBadges use OOUI
......................................................................


Make Special:EntityUsage and Special:PagesWithBadges use OOUI

Bug: T152046
Change-Id: Icdff99844be2e65e547111ae26b2432a6e735c42
---
M client/includes/Specials/SpecialEntityUsage.php
M client/includes/Specials/SpecialPagesWithBadges.php
M client/tests/phpunit/includes/Specials/SpecialPagesWithBadgesTest.php
3 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  WMDE-leszek: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/includes/Specials/SpecialEntityUsage.php 
b/client/includes/Specials/SpecialEntityUsage.php
index 7451b5f..9f982d6 100644
--- a/client/includes/Specials/SpecialEntityUsage.php
+++ b/client/includes/Specials/SpecialEntityUsage.php
@@ -111,7 +111,7 @@
                        $formDescriptor['entity']['default'] = 
$this->entityId->getSerialization();
                }
 
-               return HTMLForm::factory( 'inline', $formDescriptor, 
$this->getContext() )
+               return HTMLForm::factory( 'ooui', $formDescriptor, 
$this->getContext() )
                        ->setMethod( 'get' )
                        ->setWrapperLegendMsg( 'wikibase-entityusage-legend' )
                        ->suppressDefaultSubmit()
diff --git a/client/includes/Specials/SpecialPagesWithBadges.php 
b/client/includes/Specials/SpecialPagesWithBadges.php
index 330ccb3..7832fb4 100644
--- a/client/includes/Specials/SpecialPagesWithBadges.php
+++ b/client/includes/Specials/SpecialPagesWithBadges.php
@@ -142,7 +142,7 @@
                        $formDescriptor['badge']['default'] = 
$this->badgeId->getSerialization();
                }
 
-               return HTMLForm::factory( 'inline', $formDescriptor, 
$this->getContext() )
+               return HTMLForm::factory( 'ooui', $formDescriptor, 
$this->getContext() )
                        ->setMethod( 'get' )
                        ->setWrapperLegendMsg( 
'wikibase-pageswithbadges-legend' )
                        ->suppressDefaultSubmit()
diff --git 
a/client/tests/phpunit/includes/Specials/SpecialPagesWithBadgesTest.php 
b/client/tests/phpunit/includes/Specials/SpecialPagesWithBadgesTest.php
index 1826cb7..be39484 100644
--- a/client/tests/phpunit/includes/Specials/SpecialPagesWithBadgesTest.php
+++ b/client/tests/phpunit/includes/Specials/SpecialPagesWithBadgesTest.php
@@ -69,9 +69,9 @@
        public function testExecuteWithoutAnyParams() {
                list( $result, ) = $this->executeSpecialPage( '' );
 
-               $this->assertContains( '<select name="badge"', $result );
-               $this->assertContains( '<option value="Q123"', $result );
-               $this->assertContains( '<option value="Q456"', $result );
+               $this->assertContains( "<select tabindex='0' 
aria-disabled='false' name='badge'", $result );
+               $this->assertContains( "<option value='Q123'", $result );
+               $this->assertContains( "<option value='Q456'", $result );
 
                $this->assertContains( 'Label of Q123', $result );
                $this->assertContains( 'Label of Q456', $result );
@@ -80,7 +80,7 @@
        public function testExecuteWithValidParam() {
                list( $result, ) = $this->executeSpecialPage( 'Q456' );
 
-               $this->assertContains( '<option value="Q456" selected=""', 
$result );
+               $this->assertContains( "<option value='Q456' 
selected='selected'", $result );
        }
 
        public function testExecuteWithInvalidParam() {

-- 
To view, visit https://gerrit.wikimedia.org/r/324562
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icdff99844be2e65e547111ae26b2432a6e735c42
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Thiemo M├Ąttig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to