Milimetric has submitted this change and it was merged.

Change subject: Do not record empty metrics
......................................................................


Do not record empty metrics

Bug: T147034

Change-Id: I4da6e47ec90d87e04fd8e55a7ad9942a1ba8f1d7
---
M reportupdater/graphite.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Milimetric: Verified; Looks good to me, approved



diff --git a/reportupdater/graphite.py b/reportupdater/graphite.py
index 84da9e8..2ba648a 100644
--- a/reportupdater/graphite.py
+++ b/reportupdater/graphite.py
@@ -60,7 +60,8 @@
 
         for metric in report.graphite['metrics']:
             (metric, value, timestamp) = self.get_graphite_data(report, row, 
metric)
-            self.record(metric, value, timestamp)
+            if value is not None:
+                self.record(metric, value, timestamp)
 
     def get_graphite_data(self, report, row, metric):
         header = report.results['header']

-- 
To view, visit https://gerrit.wikimedia.org/r/324635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4da6e47ec90d87e04fd8e55a7ad9942a1ba8f1d7
Gerrit-PatchSet: 3
Gerrit-Project: analytics/reportupdater
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: Milimetric <dandree...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to