jenkins-bot has submitted this change and it was merged.

Change subject: Fix the event sampling being overriden by other events
......................................................................


Fix the event sampling being overriden by other events

Bug: T152162
Change-Id: I8e9a7240766e6631d7426d46b8c96e73baf66c75
---
M modules/ext.wikimediaEvents.kartographer.js
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.wikimediaEvents.kartographer.js 
b/modules/ext.wikimediaEvents.kartographer.js
index d49789c..41d14fd 100644
--- a/modules/ext.wikimediaEvents.kartographer.js
+++ b/modules/ext.wikimediaEvents.kartographer.js
@@ -152,16 +152,16 @@
                        switch ( data.action ) {
                                case 'initialize':
                                        data.feature.on( 'click contextmenu', 
function () {
-                                               options = $.extend( {}, 
options, { sampling: 100 } );
-                                               logEvent( 
data.feature.featureType, 'map-click', data.isFullScreen, options );
+                                               var opts = $.extend( {}, 
options, { sampling: 100 } );
+                                               logEvent( 
data.feature.featureType, 'map-click', data.isFullScreen, opts );
                                        } );
                                        data.feature.on( 'zoomend', function () 
{
-                                               options = $.extend( {}, 
options, { sampling: 100 } );
-                                               logEvent( 
data.feature.featureType, 'zoom', data.isFullScreen, options );
+                                               var opts = $.extend( {}, 
options, { sampling: 100 } );
+                                               logEvent( 
data.feature.featureType, 'zoom', data.isFullScreen, opts );
                                        } );
                                        data.feature.on( 'dragend', function () 
{
-                                               options = $.extend( {}, 
options, { sampling: 100 } );
-                                               logEvent( 
data.feature.featureType, 'drag', data.isFullScreen, options );
+                                               var opts = $.extend( {}, 
options, { sampling: 100 } );
+                                               logEvent( 
data.feature.featureType, 'drag', data.isFullScreen, opts );
                                        } );
                                        data.feature.on( 'popupopen', function 
() {
                                                logEvent( 
data.feature.featureType, 'marker-click', data.isFullScreen, options );

-- 
To view, visit https://gerrit.wikimedia.org/r/324846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e9a7240766e6631d7426d46b8c96e73baf66c75
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: JGirault <julien.inbox.w...@gmail.com>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to