jenkins-bot has submitted this change and it was merged.

Change subject: Minor fixes: comments, obsolete stuff
......................................................................


Minor fixes: comments, obsolete stuff

Change-Id: I213f50e860fae113dc7b20a2fc343b69870cceb3
---
M generateTables.php
1 file changed, 6 insertions(+), 57 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/generateTables.php b/generateTables.php
index bf2e166..2919fa8 100644
--- a/generateTables.php
+++ b/generateTables.php
@@ -1,9 +1,8 @@
 <?php
 
 /**
- * WikiHiero - A PHP convert from text using "Manual for the encoding of
- * hieroglyphic texts for computer input" syntax to HTML entities (table and
- * images).
+ * This maintenance script regenerates data tables used for
+ * hieroglyphics rendering.
  *
  * Copyright (C) 2004 Guillaume Blanchard (Aoineko)
  *
@@ -33,7 +32,7 @@
 
        public function __construct() {
                parent::__construct();
-               $this->mDescription = 'Generate tables with hieroglyph 
information';
+               $this->addDescription( 'Generate tables with hieroglyph 
information' );
                $this->requireExtension( 'WikiHiero' );
 
                $this->moreTables = str_replace( "\r", '', $this->moreTables );
@@ -50,7 +49,7 @@
                        if ( $dh ) {
                                while ( ( $file = readdir( $dh ) ) !== false ) {
                                        if ( stristr( $file, 
WikiHiero::IMAGE_EXT ) ) {
-                                               list( $width, $height, $type, 
$attr ) = getimagesize( $imgDir . $file );
+                                               list( $width, $height, , ) = 
getimagesize( $imgDir . $file );
                                                $wh_files .= "  \"" . 
WikiHiero::getCode( $file ) . "\" => array( $width, $height ),\n";
                                                if ( strchr( $file, '&' ) ) {
                                                        $wh_prefabs .= "  \"" . 
WikiHiero::getCode( $file ) . "\",\n";
@@ -85,8 +84,8 @@
                file_put_contents( 'data/tables.ser', serialize( $result ) );
        }
 
-       var $moreTables = '
-$wh_phonemes   =       array(  //      convertion      table   phoneme ->      
Gardiner        code
+       private $moreTables = '
+$wh_phonemes   =       array( // phoneme -> Gardiner code conversion table
        "mSa"   =>      "A12",
        "xr"    =>      "A15",
        "Xrd"   =>      "A17",
@@ -511,56 +510,6 @@
        "\']"   =>      "",
 );
 ';
-
-/* not used yet
-$wh_syntax = array(
-  "-",    //block sepatator
-  ":",    //supperposition
-  "*",    //juxtaposition
-  "(",    //open bracket
-  ")",    //close bracket
-  "!!",   //end of text
-  "!",    //end of line
-  "..",   //blank caracter
-  ".",    //half-size blank caracter
-  "$",    //color
-  "#",    //shade
-  "[&",   //select
-  "&]",
-  "[{",
-  "}]",
-  "[[",
-  "]]",
-  "[\"",
-  "\"]",
-  "['",
-  "']",
-  "<",    //cartouche
-  ">",
-  "<1",
-  "2>",
-  "<2",
-  "1>",
-  "<0",
-  "0>",
-  "<h1",  //horus
-  "h1>",
-  "<h2",
-  "h2>",
-  "<h3",
-  "h3>",
-  "<h0",
-  "h0>",
-  "++",   //comment
-  "+s",   //hieroglyph
-  "+t",   //transcription
-  "+l",   //latin-normal
-  "+i",   //latin-italic
-  "+g",   //latin-bold (gras)
-  "+b",   //latin-bold
-  "+c",
-);
-*/
 
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/324814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I213f50e860fae113dc7b20a2fc343b69870cceb3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/wikihiero
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to