IAlex has submitted this change and it was merged.

Change subject: InfoAction: Heading ID should not include # character.
......................................................................


InfoAction: Heading ID should not include # character.

It was using Parser::guessSectionNameFromWikiText, which expects
a string of wikitext (e.g. "== Foo ==") and extracts the heading
text, and from that it generates an ID, and from that it
generates an anchor link.

The extraction and anchor link are wrong and caused the output
to be <h2 id="#Foo"> instead of <h2 id="Foo">.

Follows up I702f2f13.

Bug: 44989
Change-Id: I81f67ae1ac86ed709c69f1bced970b2cbb5138db
---
M includes/actions/InfoAction.php
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  IAlex: Looks good to me, approved



-- 
To view, visit https://gerrit.wikimedia.org/r/49016
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I81f67ae1ac86ed709c69f1bced970b2cbb5138db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to