jenkins-bot has submitted this change and it was merged. Change subject: Added TODO for "values from concept" ......................................................................
Added TODO for "values from concept" Change-Id: I640483184a0e8a8cf59c4f2189192cb7709b96a3 --- M includes/PF_ValuesUtils.php 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Yaron Koren: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/PF_ValuesUtils.php b/includes/PF_ValuesUtils.php index c8ac4a2..5d07e3d 100644 --- a/includes/PF_ValuesUtils.php +++ b/includes/PF_ValuesUtils.php @@ -252,6 +252,10 @@ // be better to do this filtering in the // original SMW query, but that doesn't seem // possible yet. + // @TODO - this will miss a lot of results for + // concepts with > 1000 pages. Instead, this + // code should loop through all the pages, + // using "offset". $lowercasePageName = strtolower( $pageName ); if ( $wgPageFormsAutocompleteOnAllChars ) { if ( strpos( $lowercasePageName, $substring ) >= 0 ) { -- To view, visit https://gerrit.wikimedia.org/r/325375 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640483184a0e8a8cf59c4f2189192cb7709b96a3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/PageForms Gerrit-Branch: master Gerrit-Owner: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits