jenkins-bot has submitted this change and it was merged.
Change subject: Do not give validation error on address with no location_type.
......................................................................
Do not give validation error on address with no location_type.
To replicate create a contact with 2 * civicrm_address records for the same
location type.
On save load one will lose it's type & then it will fail to save. In the case
of 'email' an alternative gets selected.
This is the super quick hack version. I want to follow it with a version that
will do clean up rather than just ignore. However, the feeling is ignore is
better than cause inconvenience or ask Engage staff to fix at this stage.
Bug: T152426
Change-Id: Ibcf1a34abbaad8e986afef82c4fbf41facad9d7c
---
M CRM/Contact/Form/Contact.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CRM/Contact/Form/Contact.php b/CRM/Contact/Form/Contact.php
index 1c04b66..9dae4be 100644
--- a/CRM/Contact/Form/Contact.php
+++ b/CRM/Contact/Form/Contact.php
@@ -654,7 +654,7 @@
}
if (empty($blockValues['location_type_id'])) {
- $errors["{$name}[$instance][location_type_id]"] = ts('The
Location Type should be set if there is %1 information.', array(1 => $label));
+ //$errors["{$name}[$instance][location_type_id]"] = ts('The
Location Type should be set if there is %1 information.', array(1 => $label));
}
}
--
To view, visit https://gerrit.wikimedia.org/r/325444
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcf1a34abbaad8e986afef82c4fbf41facad9d7c
Gerrit-PatchSet: 3
Gerrit-Project: wikimedia/fundraising/crm/civicrm
Gerrit-Branch: master
Gerrit-Owner: Eileen <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
