Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/325700
Change subject: Hygiene: move Mocha ESLint environment from tests to config
......................................................................
Hygiene: move Mocha ESLint environment from tests to config
Change-Id: I072fcde8cf1c0c99759452feb425601f0c3aecab
---
A test/.eslintrc.yml
M test/features/announcements/announcements.js
M test/features/app/app.js
M test/features/app/spec.js
M test/features/definition/definition.js
M test/features/featured-image/pagecontent.js
M test/features/featured/pagecontent.js
M test/features/info/info.js
M test/features/media/pagecontent.js
M test/features/mobile-sections-lead/pagecontent.js
M test/features/mobile-sections-lead/parse-pronunciation-test.js
M test/features/mobile-sections-remaining/pagecontent.js
M test/features/mobile-sections/pagecontent-v2.js
M test/features/mobile-sections/pagecontent.js
M test/features/mobile-text/pagecontent.js
M test/features/most-read/most-read.js
M test/features/most-read/page-filtering.js
M test/features/news/news.js
M test/features/random/summary.js
M test/features/random/title.js
M test/lib/anchorencode/anchorencode-test.js
M test/lib/api-util/api-util-test.js
M test/lib/app-transforms/transforms.js
M test/lib/dateUtil/date-util-test.js
M test/lib/mobile-util/mobile-util-test.js
M test/lib/mwapi/image-test.js
M test/lib/parseProperty/parseInfobox.js
M test/lib/parsoid/parsoid-access-test.js
M test/lib/size-transforms/transforms-test.js
29 files changed, 3 insertions(+), 56 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/00/325700/1
diff --git a/test/.eslintrc.yml b/test/.eslintrc.yml
new file mode 100644
index 0000000..e28757c
--- /dev/null
+++ b/test/.eslintrc.yml
@@ -0,0 +1,3 @@
+---
+env:
+ mocha: true
\ No newline at end of file
diff --git a/test/features/announcements/announcements.js
b/test/features/announcements/announcements.js
index e0fc042..f205449 100644
--- a/test/features/announcements/announcements.js
+++ b/test/features/announcements/announcements.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const preq = require('preq');
diff --git a/test/features/app/app.js b/test/features/app/app.js
index ab2ee46..dbafca1 100644
--- a/test/features/app/app.js
+++ b/test/features/app/app.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
diff --git a/test/features/app/spec.js b/test/features/app/spec.js
index 8998723..5b2fd7b 100644
--- a/test/features/app/spec.js
+++ b/test/features/app/spec.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
diff --git a/test/features/definition/definition.js
b/test/features/definition/definition.js
index 1dff3d1..e8f4265 100644
--- a/test/features/definition/definition.js
+++ b/test/features/definition/definition.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/features/featured-image/pagecontent.js
b/test/features/featured-image/pagecontent.js
index 3cede14..e29b0b2 100644
--- a/test/features/featured-image/pagecontent.js
+++ b/test/features/featured-image/pagecontent.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/features/featured/pagecontent.js
b/test/features/featured/pagecontent.js
index af7229c..d2a7386 100644
--- a/test/features/featured/pagecontent.js
+++ b/test/features/featured/pagecontent.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const preq = require('preq');
diff --git a/test/features/info/info.js b/test/features/info/info.js
index 869d521..c68164a 100644
--- a/test/features/info/info.js
+++ b/test/features/info/info.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
diff --git a/test/features/media/pagecontent.js
b/test/features/media/pagecontent.js
index 1a77949..d8c790f 100644
--- a/test/features/media/pagecontent.js
+++ b/test/features/media/pagecontent.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/features/mobile-sections-lead/pagecontent.js
b/test/features/mobile-sections-lead/pagecontent.js
index ec2056e..52f0c8f 100644
--- a/test/features/mobile-sections-lead/pagecontent.js
+++ b/test/features/mobile-sections-lead/pagecontent.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/features/mobile-sections-lead/parse-pronunciation-test.js
b/test/features/mobile-sections-lead/parse-pronunciation-test.js
index 6ff5ab3..ff4934b 100644
--- a/test/features/mobile-sections-lead/parse-pronunciation-test.js
+++ b/test/features/mobile-sections-lead/parse-pronunciation-test.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/features/mobile-sections-remaining/pagecontent.js
b/test/features/mobile-sections-remaining/pagecontent.js
index 241b0c8..eb88ccf 100644
--- a/test/features/mobile-sections-remaining/pagecontent.js
+++ b/test/features/mobile-sections-remaining/pagecontent.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const server = require('../../utils/server.js');
diff --git a/test/features/mobile-sections/pagecontent-v2.js
b/test/features/mobile-sections/pagecontent-v2.js
index f4b03d6..8276acd 100644
--- a/test/features/mobile-sections/pagecontent-v2.js
+++ b/test/features/mobile-sections/pagecontent-v2.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/features/mobile-sections/pagecontent.js
b/test/features/mobile-sections/pagecontent.js
index a9d2444..ee67b4d 100644
--- a/test/features/mobile-sections/pagecontent.js
+++ b/test/features/mobile-sections/pagecontent.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const preq = require('preq');
diff --git a/test/features/mobile-text/pagecontent.js
b/test/features/mobile-text/pagecontent.js
index 1347fd7..a9bfb35 100644
--- a/test/features/mobile-text/pagecontent.js
+++ b/test/features/mobile-text/pagecontent.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/features/most-read/most-read.js
b/test/features/most-read/most-read.js
index 959f4d8..6871f08 100644
--- a/test/features/most-read/most-read.js
+++ b/test/features/most-read/most-read.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const preq = require('preq');
diff --git a/test/features/most-read/page-filtering.js
b/test/features/most-read/page-filtering.js
index c7c3c0b..5ee343c 100644
--- a/test/features/most-read/page-filtering.js
+++ b/test/features/most-read/page-filtering.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const fs = require('fs');
diff --git a/test/features/news/news.js b/test/features/news/news.js
index 5e6a9c5..199b43a 100644
--- a/test/features/news/news.js
+++ b/test/features/news/news.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const preq = require('preq');
diff --git a/test/features/random/summary.js b/test/features/random/summary.js
index 6b3361f..421cb51 100644
--- a/test/features/random/summary.js
+++ b/test/features/random/summary.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/features/random/title.js b/test/features/random/title.js
index fe15684..c0412dc 100644
--- a/test/features/random/title.js
+++ b/test/features/random/title.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const preq = require('preq');
diff --git a/test/lib/anchorencode/anchorencode-test.js
b/test/lib/anchorencode/anchorencode-test.js
index 4b18c31..b2eedd5 100644
--- a/test/lib/anchorencode/anchorencode-test.js
+++ b/test/lib/anchorencode/anchorencode-test.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/lib/api-util/api-util-test.js
b/test/lib/api-util/api-util-test.js
index b5f6333..33ef32b 100644
--- a/test/lib/api-util/api-util-test.js
+++ b/test/lib/api-util/api-util-test.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const preq = require('preq');
diff --git a/test/lib/app-transforms/transforms.js
b/test/lib/app-transforms/transforms.js
index afd94a8..ccd48a5 100644
--- a/test/lib/app-transforms/transforms.js
+++ b/test/lib/app-transforms/transforms.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const fs = require('fs');
diff --git a/test/lib/dateUtil/date-util-test.js
b/test/lib/dateUtil/date-util-test.js
index 500a45f..8290d12 100644
--- a/test/lib/dateUtil/date-util-test.js
+++ b/test/lib/dateUtil/date-util-test.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/lib/mobile-util/mobile-util-test.js
b/test/lib/mobile-util/mobile-util-test.js
index bc3a01c..5fb1150 100644
--- a/test/lib/mobile-util/mobile-util-test.js
+++ b/test/lib/mobile-util/mobile-util-test.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert');
diff --git a/test/lib/mwapi/image-test.js b/test/lib/mwapi/image-test.js
index 4ba2543..96b68c8 100644
--- a/test/lib/mwapi/image-test.js
+++ b/test/lib/mwapi/image-test.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/lib/parseProperty/parseInfobox.js
b/test/lib/parseProperty/parseInfobox.js
index 92d18a0..9f2c45c 100644
--- a/test/lib/parseProperty/parseInfobox.js
+++ b/test/lib/parseProperty/parseInfobox.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const fs = require('fs');
diff --git a/test/lib/parsoid/parsoid-access-test.js
b/test/lib/parsoid/parsoid-access-test.js
index fab5946..f1a14fd 100644
--- a/test/lib/parsoid/parsoid-access-test.js
+++ b/test/lib/parsoid/parsoid-access-test.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
diff --git a/test/lib/size-transforms/transforms-test.js
b/test/lib/size-transforms/transforms-test.js
index bb7dcb6..b17adc7 100644
--- a/test/lib/size-transforms/transforms-test.js
+++ b/test/lib/size-transforms/transforms-test.js
@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
'use strict';
const assert = require('../../utils/assert.js');
--
To view, visit https://gerrit.wikimedia.org/r/325700
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I072fcde8cf1c0c99759452feb425601f0c3aecab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
